diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-08-07 22:52:32 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-08-07 22:52:32 -0500 |
commit | 0b9832119e9d42bc3ba4d8e4a4e573a03705de3e (patch) | |
tree | 632e321030eecb9795c64a60db5a516d2ca8bdb4 /components/script/dom/bindings/codegen | |
parent | fab2ab8b9e2c7f7a200f11a2b0ead259beac97df (diff) | |
parent | a3d1457809f76355764a43f6f36f10ddd9ff0948 (diff) | |
download | servo-0b9832119e9d42bc3ba4d8e4a4e573a03705de3e.tar.gz servo-0b9832119e9d42bc3ba4d8e4a4e573a03705de3e.zip |
Auto merge of #12751 - emilio:transitions-raf, r=pcwalton
compositor: Send animation ticks to layout even if there are script animation frames.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12749 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
The script tick ends up only processing JS callbacks related to animation
frames, so CSS transitions/animations end up not working as expected.
This could have accidentally worked before #12563 because we over-restyled, but
now this is no longer the case.
Other possible way to do it is making a layout reflow with RAF handle CSS
animations/transitions too, but that may not work if the reflow ends up being
suppressed (that could very well be the case), and we'd need to handle a lot
more state in the document, so this solution (assuming it doesn't break try)
seems a bit less flacky.
Missing a test, will add one soon. Fixes #12749.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12751)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen')
0 files changed, 0 insertions, 0 deletions