aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/bindings/codegen/test
diff options
context:
space:
mode:
authorCorey Farwell <coreyf@rwell.org>2015-07-05 12:10:53 -0700
committerCorey Farwell <coreyf@rwell.org>2015-07-09 19:42:31 +0900
commit0ec2375cabb69abbfd1014bfb68136fdea6edadb (patch)
tree8a24a61ae92605810bdd7163aad10204833e9a99 /components/script/dom/bindings/codegen/test
parentfe17067d6a30b85a0346fd1ccb2b95e2081e6962 (diff)
downloadservo-0ec2375cabb69abbfd1014bfb68136fdea6edadb.tar.gz
servo-0ec2375cabb69abbfd1014bfb68136fdea6edadb.zip
Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that live in 'components/script/dom/bindings/*' and noticed that there were many tidy violations: unnecessary semicolons, weird spacing, unused variables, lack of license headers, etc. Considering these files are now living in our tree and mostly maintained directly by contributors of Servo (as opposed to being from upstream), I feel these files should not be excluded from our normal tidy process. This commit removes the blacklist on these files and fixes all tidy violations. I added these subdirectories to the blacklist because they appear to be maintained upstream somewhere else: * "components/script/dom/bindings/codegen/parser/*", * "components/script/dom/bindings/codegen/ply/*", Also, I added a '# noqa' comment which tells us to ignore the flake8 errors for that line. I chose to ignore this (instead of fixing it) to make the work for this commit simpler for me.
Diffstat (limited to 'components/script/dom/bindings/codegen/test')
-rw-r--r--components/script/dom/bindings/codegen/test/TestBindingHeader.h10
1 files changed, 5 insertions, 5 deletions
diff --git a/components/script/dom/bindings/codegen/test/TestBindingHeader.h b/components/script/dom/bindings/codegen/test/TestBindingHeader.h
index 1fbab0a9fb8..20e01813119 100644
--- a/components/script/dom/bindings/codegen/test/TestBindingHeader.h
+++ b/components/script/dom/bindings/codegen/test/TestBindingHeader.h
@@ -1,8 +1,7 @@
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this file,
- * You can obtain one at http://mozilla.org/MPL/2.0/.
- */
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef TestBindingHeader_h
#define TestBindingHeader_h
@@ -126,7 +125,7 @@ public:
const TestInterfaceOrOnlyForUseInConstructor&,
ErrorResult&);
*/
-
+
// Integer types
int8_t ReadonlyByte();
int8_t WritableByte();
@@ -215,7 +214,8 @@ public:
void ReceiveNonWrapperCacheInterfaceSequence(nsTArray<nsRefPtr<TestNonWrapperCacheInterface> >&);
void ReceiveNullableNonWrapperCacheInterfaceSequence(nsTArray<nsRefPtr<TestNonWrapperCacheInterface> >&);
void ReceiveNonWrapperCacheInterfaceNullableSequence(Nullable<nsTArray<nsRefPtr<TestNonWrapperCacheInterface> > >&);
- void ReceiveNullableNonWrapperCacheInterfaceNullableSequence(Nullable<nsTArray<nsRefPtr<TestNonWrapperCacheInterface> > >&);
+ void ReceiveNullableNonWrapperCacheInterfaceNullableSequence(
+ Nullable<nsTArray<nsRefPtr<TestNonWrapperCacheInterface> > >&);
already_AddRefed<TestNonCastableInterface> ReceiveOther();
already_AddRefed<TestNonCastableInterface> ReceiveNullableOther();