aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/bindings/codegen/GlobalGen.py
diff options
context:
space:
mode:
authorCorey Farwell <coreyf@rwell.org>2015-07-05 12:10:53 -0700
committerCorey Farwell <coreyf@rwell.org>2015-07-09 19:42:31 +0900
commit0ec2375cabb69abbfd1014bfb68136fdea6edadb (patch)
tree8a24a61ae92605810bdd7163aad10204833e9a99 /components/script/dom/bindings/codegen/GlobalGen.py
parentfe17067d6a30b85a0346fd1ccb2b95e2081e6962 (diff)
downloadservo-0ec2375cabb69abbfd1014bfb68136fdea6edadb.tar.gz
servo-0ec2375cabb69abbfd1014bfb68136fdea6edadb.zip
Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that live in 'components/script/dom/bindings/*' and noticed that there were many tidy violations: unnecessary semicolons, weird spacing, unused variables, lack of license headers, etc. Considering these files are now living in our tree and mostly maintained directly by contributors of Servo (as opposed to being from upstream), I feel these files should not be excluded from our normal tidy process. This commit removes the blacklist on these files and fixes all tidy violations. I added these subdirectories to the blacklist because they appear to be maintained upstream somewhere else: * "components/script/dom/bindings/codegen/parser/*", * "components/script/dom/bindings/codegen/ply/*", Also, I added a '# noqa' comment which tells us to ignore the flake8 errors for that line. I chose to ignore this (instead of fixing it) to make the work for this commit simpler for me.
Diffstat (limited to 'components/script/dom/bindings/codegen/GlobalGen.py')
-rw-r--r--components/script/dom/bindings/codegen/GlobalGen.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/components/script/dom/bindings/codegen/GlobalGen.py b/components/script/dom/bindings/codegen/GlobalGen.py
index e596ea44f51..1bebc213e38 100644
--- a/components/script/dom/bindings/codegen/GlobalGen.py
+++ b/components/script/dom/bindings/codegen/GlobalGen.py
@@ -1,6 +1,6 @@
# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this file,
-# You can obtain one at http://mozilla.org/MPL/2.0/.
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
# We do one global pass over all the WebIDL to generate our prototype enum
# and generate information for subsequent phases.
@@ -9,12 +9,12 @@ import sys
sys.path.append("./parser/")
sys.path.append("./ply/")
import os
-import cStringIO
import WebIDL
import cPickle
-from Configuration import *
+from Configuration import Configuration
from CodegenRust import GlobalGenRoots, replaceFileIfChanged
+
def generate_file(config, name, filename):
root = getattr(GlobalGenRoots, name)(config)
code = root.define()
@@ -24,6 +24,7 @@ def generate_file(config, name, filename):
else:
print "%s hasn't changed - not touching it" % (filename)
+
def main():
# Parse arguments.
from optparse import OptionParser