diff options
author | bors-servo <metajack+bors@gmail.com> | 2015-07-09 07:55:27 -0600 |
---|---|---|
committer | bors-servo <metajack+bors@gmail.com> | 2015-07-09 07:55:27 -0600 |
commit | 2d2a340633dcc73e458a8454b78e26ba93511d37 (patch) | |
tree | 8a24a61ae92605810bdd7163aad10204833e9a99 /components/script/dom/bindings/codegen/GlobalGen.py | |
parent | fe17067d6a30b85a0346fd1ccb2b95e2081e6962 (diff) | |
parent | 0ec2375cabb69abbfd1014bfb68136fdea6edadb (diff) | |
download | servo-2d2a340633dcc73e458a8454b78e26ba93511d37.tar.gz servo-2d2a340633dcc73e458a8454b78e26ba93511d37.zip |
Auto merge of #6580 - frewsxcv:lint-codegen, r=Ms2ger
Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that
live in 'components/script/dom/bindings/*' and noticed that there were
many tidy violations: unnecessary semicolons, weird spacing, unused
variables, lack of license headers, etc. Considering these files are now
living in our tree and mostly maintained directly by contributors of
Servo (as opposed to being from upstream), I feel these files should not
be excluded from our normal tidy process. This commit removes the
blacklist on these files and fixes all tidy violations.
I added these subdirectories to the blacklist because they appear to be
maintained upstream somewhere else:
* "components/script/dom/bindings/codegen/parser/*",
* "components/script/dom/bindings/codegen/ply/*",
Also, I added a few '# noqa' comments which tells us to ignore the
flake8 errors for that line; they are mostly for unused/undefined
variables. I chose to ignore these (instead of fixing them) to make the
work for this commit simpler for me.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6580)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen/GlobalGen.py')
-rw-r--r-- | components/script/dom/bindings/codegen/GlobalGen.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/components/script/dom/bindings/codegen/GlobalGen.py b/components/script/dom/bindings/codegen/GlobalGen.py index e596ea44f51..1bebc213e38 100644 --- a/components/script/dom/bindings/codegen/GlobalGen.py +++ b/components/script/dom/bindings/codegen/GlobalGen.py @@ -1,6 +1,6 @@ # This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this file, -# You can obtain one at http://mozilla.org/MPL/2.0/. +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. # We do one global pass over all the WebIDL to generate our prototype enum # and generate information for subsequent phases. @@ -9,12 +9,12 @@ import sys sys.path.append("./parser/") sys.path.append("./ply/") import os -import cStringIO import WebIDL import cPickle -from Configuration import * +from Configuration import Configuration from CodegenRust import GlobalGenRoots, replaceFileIfChanged + def generate_file(config, name, filename): root = getattr(GlobalGenRoots, name)(config) code = root.define() @@ -24,6 +24,7 @@ def generate_file(config, name, filename): else: print "%s hasn't changed - not touching it" % (filename) + def main(): # Parse arguments. from optparse import OptionParser |