diff options
| author | Patrick Shaughnessy <pshaughn@comcast.net> | 2020-01-06 14:20:51 -0500 |
|---|---|---|
| committer | Patrick Shaughnessy <pshaughn@comcast.net> | 2020-01-10 12:32:08 -0500 |
| commit | 111ede9c77a41ab353f12683a62cd4b4dabb65da (patch) | |
| tree | 5b144e41939bedff601c8755dd67b78e0c78fac5 /components/script/dom/bindings/codegen/CodegenRust.py | |
| parent | 1d645f37418719a3f965f5729543c97c2d057d01 (diff) | |
| download | servo-111ede9c77a41ab353f12683a62cd4b4dabb65da.tar.gz servo-111ede9c77a41ab353f12683a62cd4b4dabb65da.zip | |
Make property descriptors hold named/indexed property values
Diffstat (limited to 'components/script/dom/bindings/codegen/CodegenRust.py')
| -rw-r--r-- | components/script/dom/bindings/codegen/CodegenRust.py | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index ec29a59c9d4..9cdda2f3bf2 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -5147,8 +5147,7 @@ class CGDOMJSProxyHandler_getOwnPropertyDescriptor(CGAbstractExternMethod): attrs = "JSPROP_ENUMERATE" if self.descriptor.operations['IndexedSetter'] is None: attrs += " | JSPROP_READONLY" - # FIXME(#11868) Should assign to desc.value, desc.get() is a copy. - fillDescriptor = ("desc.get().value = result_root.get();\n" + fillDescriptor = ("desc.value = result_root.get();\n" "fill_property_descriptor(MutableHandle::from_raw(desc), proxy.get(), (%s) as u32);\n" "return true;" % attrs) templateValues = { @@ -5173,8 +5172,7 @@ class CGDOMJSProxyHandler_getOwnPropertyDescriptor(CGAbstractExternMethod): attrs = " | ".join(attrs) else: attrs = "0" - # FIXME(#11868) Should assign to desc.value, desc.get() is a copy. - fillDescriptor = ("desc.get().value = result_root.get();\n" + fillDescriptor = ("desc.value = result_root.get();\n" "fill_property_descriptor(MutableHandle::from_raw(desc), proxy.get(), (%s) as u32);\n" "return true;" % attrs) templateValues = { @@ -5221,7 +5219,7 @@ if !expando.is_null() { } } """ + namedGet + """\ -desc.get().obj = ptr::null_mut(); +desc.obj = ptr::null_mut(); return true;""" def definition_body(self): |