diff options
| author | bors-servo <metajack+bors@gmail.com> | 2015-08-21 09:30:06 -0600 |
|---|---|---|
| committer | bors-servo <metajack+bors@gmail.com> | 2015-08-21 09:30:06 -0600 |
| commit | 3a48e04caffa4ba25854a4190883d1985845a359 (patch) | |
| tree | 6b6b7843469d00fd7303ffa2b6251f6657c2edc4 /components/script/dom/bindings/codegen/CodegenRust.py | |
| parent | 7c45ff8e05a6ebd21f9aa5c360e997a01d48b1fc (diff) | |
| parent | 2ab43bea5d508f41790339507ed439d2709c0bfa (diff) | |
| download | servo-3a48e04caffa4ba25854a4190883d1985845a359.tar.gz servo-3a48e04caffa4ba25854a4190883d1985845a359.zip | |
Auto merge of #7305 - frewsxcv:python-context-managers, r=Ms2ger
Utilize Python context managers for opening/closing files
In some of these cases, files were not being closed
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7305)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen/CodegenRust.py')
| -rw-r--r-- | components/script/dom/bindings/codegen/CodegenRust.py | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index cd3ee9baacb..b4ed22fb447 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -41,18 +41,16 @@ def replaceFileIfChanged(filename, newContents): # oldFileContents = "" # try: - # oldFile = open(filename, 'rb') - # oldFileContents = ''.join(oldFile.readlines()) - # oldFile.close() + # with open(filename, 'rb') as oldFile: + # oldFileContents = ''.join(oldFile.readlines()) # except: # pass # if newContents == oldFileContents: # return False - f = open(filename, 'wb') - f.write(newContents) - f.close() + with open(filename, 'wb') as f: + f.write(newContents) return True |