diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-01-30 08:22:46 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-01-30 08:22:46 -0500 |
commit | 65370f17c98225f7e71c72ea2e0cb2d0a81487f3 (patch) | |
tree | 4a5fb2161c956804206ccd4c97a2a0205889ad49 /components/script/dom/bindings/codegen/CodegenRust.py | |
parent | 756bd2173a0014e1455f666727068c9bfb327d90 (diff) | |
parent | 0bafa61f7cfc4a5783828b8f64e819fd715fea63 (diff) | |
download | servo-65370f17c98225f7e71c72ea2e0cb2d0a81487f3.tar.gz servo-65370f17c98225f7e71c72ea2e0cb2d0a81487f3.zip |
Auto merge of #22771 - MaT1g3R:refactor_follow_hyperlink, r=jdm
Refactor follow_hyperlink and its callers
Now they follow the new spec stated at:
https://html.spec.whatwg.org/multipage/links.html#following-hyperlinks-2
It seems like choosing a browsing context is already done in the
follow_hyperlink method, so I have removed the TODO in
activation_behavior for HTMLAreaElement.
The tests in `tests/wpt/web-platform-tests/html/semantics/links/following-hyperlinks/`
pass in release builds, but still don't pass in dev build,
since the timeout in
`tests/wpt/web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window.js`
seems to be too short for dev builds.
Navigating to error page on failed URL parsing is still not implemented.
There seem to be potential code duplication in activation_behavior
methods for both htmlanchorelement.rs and htmlareaelement.rs, in:
let referrer_policy = match self.RelList().Contains("noreferrer".into()) {
true => Some(ReferrerPolicy::NoReferrer),
false => None,
};
I didn't pull them out to a separate function since I don't know
where I would put that new function.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22761 (GitHub issue number if applicable)
<!-- Either: -->
- [X] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22771)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen/CodegenRust.py')
0 files changed, 0 insertions, 0 deletions