diff options
author | bors-servo <metajack+bors@gmail.com> | 2015-07-09 07:55:27 -0600 |
---|---|---|
committer | bors-servo <metajack+bors@gmail.com> | 2015-07-09 07:55:27 -0600 |
commit | 2d2a340633dcc73e458a8454b78e26ba93511d37 (patch) | |
tree | 8a24a61ae92605810bdd7163aad10204833e9a99 /components/script/dom/bindings/codegen/BindingGen.py | |
parent | fe17067d6a30b85a0346fd1ccb2b95e2081e6962 (diff) | |
parent | 0ec2375cabb69abbfd1014bfb68136fdea6edadb (diff) | |
download | servo-2d2a340633dcc73e458a8454b78e26ba93511d37.tar.gz servo-2d2a340633dcc73e458a8454b78e26ba93511d37.zip |
Auto merge of #6580 - frewsxcv:lint-codegen, r=Ms2ger
Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that
live in 'components/script/dom/bindings/*' and noticed that there were
many tidy violations: unnecessary semicolons, weird spacing, unused
variables, lack of license headers, etc. Considering these files are now
living in our tree and mostly maintained directly by contributors of
Servo (as opposed to being from upstream), I feel these files should not
be excluded from our normal tidy process. This commit removes the
blacklist on these files and fixes all tidy violations.
I added these subdirectories to the blacklist because they appear to be
maintained upstream somewhere else:
* "components/script/dom/bindings/codegen/parser/*",
* "components/script/dom/bindings/codegen/ply/*",
Also, I added a few '# noqa' comments which tells us to ignore the
flake8 errors for that line; they are mostly for unused/undefined
variables. I chose to ignore these (instead of fixing them) to make the
work for this commit simpler for me.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6580)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen/BindingGen.py')
-rw-r--r-- | components/script/dom/bindings/codegen/BindingGen.py | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/components/script/dom/bindings/codegen/BindingGen.py b/components/script/dom/bindings/codegen/BindingGen.py index 408280dacfb..f4d4fcdae2a 100644 --- a/components/script/dom/bindings/codegen/BindingGen.py +++ b/components/script/dom/bindings/codegen/BindingGen.py @@ -1,16 +1,16 @@ # This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this file, -# You can obtain one at http://mozilla.org/MPL/2.0/. +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. import sys sys.path.append("./parser/") sys.path.append("./ply/") import os import cPickle -import WebIDL -from Configuration import * +from Configuration import Configuration from CodegenRust import CGBindingRoot, replaceFileIfChanged + def generate_binding_rs(config, outputprefix, webidlfile): """ |config| Is the configuration object. @@ -22,6 +22,7 @@ def generate_binding_rs(config, outputprefix, webidlfile): if replaceFileIfChanged(filename, root.define()): print "Generating binding implementation: %s" % (filename) + def main(): # Parse arguments. from optparse import OptionParser @@ -46,7 +47,7 @@ def main(): config = Configuration(configFile, parserData) # Generate the prototype classes. - generate_binding_rs(config, outputPrefix, webIDLFile); + generate_binding_rs(config, outputPrefix, webIDLFile) if __name__ == '__main__': main() |