diff options
| author | Ali <azy5030@gmail.com> | 2024-09-14 03:41:13 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-14 08:41:13 +0000 |
| commit | ed6b1b5e6a5002bdeab51214576b50b10822b5f8 (patch) | |
| tree | 44984436dcd0656813fedbb2ab679a4bdbebe029 /components/script/devtools.rs | |
| parent | 6a3cdc47ec61e9d5122dd68aba8c75c00c9e5051 (diff) | |
| download | servo-ed6b1b5e6a5002bdeab51214576b50b10822b5f8.tar.gz servo-ed6b1b5e6a5002bdeab51214576b50b10822b5f8.zip | |
clippy: Fix suggestions in `script`, `libservo`, and `servoshell` (#33453)
* fix clone on copy warning in servoshell
Signed-off-by: Ali Zein Yousuf <azy5030@gmail.com>
* Remove unecessary borrow in libservo
Signed-off-by: Ali Zein Yousuf <azy5030@gmail.com>
* Ignore too many arguments warning on create_constellation()
Signed-off-by: Ali Zein Yousuf <azy5030@gmail.com>
* fix explicit auto-deref warning
Signed-off-by: Ali Zein Yousuf <azy5030@gmail.com>
* Autofix multiple clippy warnings in components/script
Signed-off-by: Ali Zein Yousuf <azy5030@gmail.com>
---------
Signed-off-by: Ali Zein Yousuf <azy5030@gmail.com>
Diffstat (limited to 'components/script/devtools.rs')
| -rw-r--r-- | components/script/devtools.rs | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/components/script/devtools.rs b/components/script/devtools.rs index 5e68b2d198e..b818f591971 100644 --- a/components/script/devtools.rs +++ b/components/script/devtools.rs @@ -236,7 +236,7 @@ pub fn handle_get_stylesheet_style( }; Some(style.Style()) }) - .map(|style| { + .flat_map(|style| { (0..style.Length()).map(move |i| { let name = style.Item(i); NodeStyle { @@ -246,7 +246,6 @@ pub fn handle_get_stylesheet_style( } }) }) - .flatten() .collect(); Some(styles) @@ -279,7 +278,7 @@ pub fn handle_get_selectors( let rule = list.Item(j)?; let style = rule.downcast::<CSSStyleRule>()?; let selector = style.SelectorText(); - let _ = elem.Matches(selector.clone()).ok()?.then_some(())?; + elem.Matches(selector.clone()).ok()?.then_some(())?; Some((selector.into(), i)) })) }) |