diff options
author | Bailey Blankenship <bblanke@ncsu.edu> | 2019-12-01 20:19:07 -0500 |
---|---|---|
committer | Bailey Blankenship <bblanke@ncsu.edu> | 2019-12-04 18:23:28 -0500 |
commit | deae103042a14db2f62aff418fe08221a6a093ec (patch) | |
tree | ae756e6dfbd401c46420524cc46550a9023fbcc5 /components/script/canvas_state.rs | |
parent | 951dc2419af2aa4c9e79e42c73e74db54bdeb7ba (diff) | |
download | servo-deae103042a14db2f62aff418fe08221a6a093ec.tar.gz servo-deae103042a14db2f62aff418fe08221a6a093ec.zip |
Addresses Issue: Support OffscreenCanvas as CanvasImageSource #24269
Added methods to canvas_data to support drawing an offscreen canvas onto another canvas
Bug fix: Swapped OffscreenCanvas width and height parameters to match Mozilla spec
Tests: Updated metadata for 866 tests
Diffstat (limited to 'components/script/canvas_state.rs')
-rw-r--r-- | components/script/canvas_state.rs | 72 |
1 files changed, 70 insertions, 2 deletions
diff --git a/components/script/canvas_state.rs b/components/script/canvas_state.rs index 7c9ad232f30..0416c96aff0 100644 --- a/components/script/canvas_state.rs +++ b/components/script/canvas_state.rs @@ -22,6 +22,7 @@ use crate::dom::globalscope::GlobalScope; use crate::dom::htmlcanvaselement::{CanvasContext, HTMLCanvasElement}; use crate::dom::imagedata::ImageData; use crate::dom::node::{Node, NodeDamage}; +use crate::dom::offscreencanvas::{OffscreenCanvas, OffscreenCanvasContext}; use crate::dom::paintworkletglobalscope::PaintWorkletGlobalScope; use crate::dom::textmetrics::TextMetrics; use crate::euclidext::Size2DExt; @@ -222,6 +223,7 @@ impl CanvasState { fn is_origin_clean(&self, image: CanvasImageSource) -> bool { match image { CanvasImageSource::HTMLCanvasElement(canvas) => canvas.origin_is_clean(), + CanvasImageSource::OffscreenCanvas(canvas) => canvas.origin_is_clean(), CanvasImageSource::HTMLImageElement(image) => { image.same_origin(GlobalScope::entry().origin()) }, @@ -372,6 +374,9 @@ impl CanvasState { CanvasImageSource::HTMLCanvasElement(ref canvas) => { self.draw_html_canvas_element(&canvas, htmlcanvas, sx, sy, sw, sh, dx, dy, dw, dh) }, + CanvasImageSource::OffscreenCanvas(ref canvas) => { + self.draw_offscreen_canvas(&canvas, htmlcanvas, sx, sy, sw, sh, dx, dy, dw, dh) + }, CanvasImageSource::HTMLImageElement(ref image) => { // https://html.spec.whatwg.org/multipage/#img-error // If the image argument is an HTMLImageElement object that is in the broken state, @@ -408,9 +413,9 @@ impl CanvasState { result } - fn draw_html_canvas_element( + fn draw_offscreen_canvas( &self, - canvas: &HTMLCanvasElement, + canvas: &OffscreenCanvas, htmlcanvas: Option<&HTMLCanvasElement>, sx: f64, sy: f64, @@ -421,6 +426,62 @@ impl CanvasState { dw: Option<f64>, dh: Option<f64>, ) -> ErrorResult { + let canvas_size = canvas.get_size(); + let dw = dw.unwrap_or(canvas_size.width as f64); + let dh = dh.unwrap_or(canvas_size.height as f64); + let sw = sw.unwrap_or(canvas_size.width as f64); + let sh = sh.unwrap_or(canvas_size.height as f64); + + let image_size = Size2D::new(canvas_size.width as f64, canvas_size.height as f64); + // 2. Establish the source and destination rectangles + let (source_rect, dest_rect) = + self.adjust_source_dest_rects(image_size, sx, sy, sw, sh, dx, dy, dw, dh); + + if !is_rect_valid(source_rect) || !is_rect_valid(dest_rect) { + return Ok(()); + } + + let smoothing_enabled = self.state.borrow().image_smoothing_enabled; + + if let Some(context) = canvas.context() { + match *context { + OffscreenCanvasContext::OffscreenContext2d(ref context) => { + context.send_canvas_2d_msg(Canvas2dMsg::DrawImageInOther( + self.get_canvas_id(), + image_size, + dest_rect, + source_rect, + smoothing_enabled, + )); + }, + } + } else { + self.send_canvas_2d_msg(Canvas2dMsg::DrawImage( + None, + image_size, + dest_rect, + source_rect, + smoothing_enabled, + )); + } + + self.mark_as_dirty(htmlcanvas); + Ok(()) + } + + fn draw_html_canvas_element( + &self, + canvas: &HTMLCanvasElement, // source canvas + htmlcanvas: Option<&HTMLCanvasElement>, // destination canvas + sx: f64, + sy: f64, + sw: Option<f64>, + sh: Option<f64>, + dx: f64, + dy: f64, + dw: Option<f64>, + dh: Option<f64>, + ) -> ErrorResult { // 1. Check the usability of the image argument if !canvas.is_valid() { return Err(Error::InvalidState); @@ -842,6 +903,13 @@ impl CanvasState { .unwrap_or_else(|| vec![0; size.area() as usize * 4]); (data, size) }, + CanvasImageSource::OffscreenCanvas(ref canvas) => { + let (data, size) = canvas.fetch_all_data().ok_or(Error::InvalidState)?; + let data = data + .map(|data| data.to_vec()) + .unwrap_or_else(|| vec![0; size.area() as usize * 4]); + (data, size) + }, CanvasImageSource::CSSStyleValue(ref value) => value .get_url(self.base_url.clone()) .and_then(|url| self.fetch_image_data(url, None)) |