diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2024-02-23 09:14:10 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-23 08:14:10 +0000 |
| commit | 9c0561536d37f64c028d67648091a314b5b88f6f (patch) | |
| tree | d9376aebb1970cb89adb76b610e7176a58e7c7da /components/net | |
| parent | 4849ba901efab9304d71b316ec9e0d7e98e1993b (diff) | |
| download | servo-9c0561536d37f64c028d67648091a314b5b88f6f.tar.gz servo-9c0561536d37f64c028d67648091a314b5b88f6f.zip | |
script: Do not run layout in a thread (#31346)
* script: Do not run layout in a thread
Instead of spawning a thread for layout that almost always runs
synchronously with script, simply run layout in the script thread.
This is a resurrection of #28708, taking just the bits that remove the
layout thread. It's a complex change and thus is just a first step
toward cleaning up the interface between script and layout. Messages are
still passed from script to layout via a `process()` method and script
proxies some messages to layout from other threads as well.
Big changes:
1. Layout is created in the script thread on Document load, thus every
live document is guaranteed to have a layout. This isn't completely
hidden in the interface, but we can safely `unwrap()` on a Document's
layout.
2. Layout configuration is abstracted away into a LayoutConfig struct
and the LayoutFactory is a struct passed around by the Constellation.
This is to avoid having to monomorphize the entire script thread
for each layout.
3. Instead of having the Constellation block on the layout thread to
figure out the current epoch and whether there are pending web fonts
loading, updates are sent synchronously to the Constellation when
rendering to a screenshot. This practically only used by the WPT.
A couple tests start to fail, which is probably inevitable since removing
the layout thread has introduced timing changes in "exit after load" and
screenshot behavior.
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
* Update test expectations
* Fix some issues found during review
* Clarify some comments
* Address review comments
---------
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/net')
| -rw-r--r-- | components/net/image_cache.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/net/image_cache.rs b/components/net/image_cache.rs index 684b57c2e20..6a25aad9818 100644 --- a/components/net/image_cache.rs +++ b/components/net/image_cache.rs @@ -29,7 +29,7 @@ use webrender_api::{ImageData, ImageDescriptor, ImageDescriptorFlags, ImageForma /// TODO(gw): Remaining work on image cache: /// * Make use of the prefetch support in various parts of the code. /// * Profile time in GetImageIfAvailable - might be worth caching these -/// results per paint / layout thread. +/// results per paint / layout. /// /// MAYBE(Yoric): /// * For faster lookups, it might be useful to store the LoadKey in the |