diff options
author | Philip Lamb <phil.git@eden.net.nz> | 2024-04-12 09:51:23 +1200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-11 21:51:23 +0000 |
commit | 10ec8565eaa0e9e86d3a6506ab1e83d5a41f51c8 (patch) | |
tree | 107d39dc9ceb56eb44c0c65982f3e21c60502835 /components/net/tests/fetch.rs | |
parent | 62a25fdcc4165ecafc6f40adc8a3e2c47838e4a3 (diff) | |
download | servo-10ec8565eaa0e9e86d3a6506ab1e83d5a41f51c8.tar.gz servo-10ec8565eaa0e9e86d3a6506ab1e83d5a41f51c8.zip |
Fixes for HTTP header compliance. (#32024)
- Fix 400 errors from nginx in response to Servo requests by implementing conformant albeit non-normative removal of whitespace from `Accept` and `Accept-Language` HTTP headers. (To match behaviour of Firefox, Safari, and Chrome) https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.2
- Provide `Host` header as REQUIRED by HTTP protocol https://www.rfc-editor.org/rfc/rfc9110#field.host
- Update tests.
Diffstat (limited to 'components/net/tests/fetch.rs')
-rw-r--r-- | components/net/tests/fetch.rs | 21 |
1 files changed, 15 insertions, 6 deletions
diff --git a/components/net/tests/fetch.rs b/components/net/tests/fetch.rs index c4409e7d6d5..7b9a140bcb4 100644 --- a/components/net/tests/fetch.rs +++ b/components/net/tests/fetch.rs @@ -1350,20 +1350,29 @@ fn test_fetch_with_devtools() { //Creating default headers for request let mut headers = HeaderMap::new(); - headers.insert( - header::ACCEPT_ENCODING, - HeaderValue::from_static("gzip, deflate, br"), - ); - headers.insert(header::ACCEPT, HeaderValue::from_static("*/*")); headers.insert( header::ACCEPT_LANGUAGE, - HeaderValue::from_static("en-US, en; q=0.5"), + HeaderValue::from_static("en-US,en;q=0.5"), ); headers.typed_insert::<UserAgent>(DEFAULT_USER_AGENT.parse().unwrap()); + let host = if url.port().is_none() { + url.host_str().unwrap().to_string() + } else { + format!("{}:{}", url.host_str().unwrap(), url.port().unwrap()) + }; + headers.typed_insert(headers::Host::from( + host.parse::<http::uri::Authority>().unwrap(), + )); + + headers.insert( + header::ACCEPT_ENCODING, + HeaderValue::from_static("gzip, deflate, br"), + ); + let httprequest = DevtoolsHttpRequest { url: url, method: Method::GET, |