diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-07-03 12:51:15 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-07-03 12:51:15 -0700 |
commit | 212aa4437e06af72ed3a215a1b49a4b1121f6398 (patch) | |
tree | d8b08b934791fc76df81064f2ac388cfe1e63540 /components/net/blob_loader.rs | |
parent | b832f2b79f8d2fd08b2e610b004591162155ce7c (diff) | |
parent | 62345ae14daeab275671ab8f45b20c47887bca27 (diff) | |
download | servo-212aa4437e06af72ed3a215a1b49a4b1121f6398.tar.gz servo-212aa4437e06af72ed3a215a1b49a4b1121f6398.zip |
Auto merge of #12185 - emilio:dont-reexpire-animations, r=nox
style: Do not re-expire animations.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12171 (github issue number if applicable).
<!-- Either: -->
- [x] These changes do not have tests because they depend on weird timing conditions.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
If we're restyling a page with animations and layout takes too long, we
might still have the expired animations from the last restyle, without these
being cleared out by layout on `tick_animations`.
Unfortunately it's hard (near to impossible?) to make a reduced test case for
this, since it heavily depends on the speed of the build and conditions that
only happen under heavy loads.
Mainly, it depends on how accurately the `TickAllAnimations` message is sent
from the constellation.
Thus, we can't just re-expire an animation, and we should re-check for it as a
previous animation.
Fixes #12171
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12185)
<!-- Reviewable:end -->
Diffstat (limited to 'components/net/blob_loader.rs')
0 files changed, 0 insertions, 0 deletions