diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-11-06 12:33:34 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-11-06 12:33:34 -0500 |
commit | 7474b309b45403a031c7b69c31d99f00d3bfcfb8 (patch) | |
tree | 9ab33e43acf8ae5659ea771956fc833eb0e3412b /components/layout_thread_2020 | |
parent | a931a80cf5ad644cba8d8445cd0a62e55f04b906 (diff) | |
parent | 1c3da95b70fe9d38d86e05ad3445346dddb450c5 (diff) | |
download | servo-7474b309b45403a031c7b69c31d99f00d3bfcfb8.tar.gz servo-7474b309b45403a031c7b69c31d99f00d3bfcfb8.zip |
Auto merge of #24634 - paulrouget:url, r=jdm
Do not assume UWP and Servo agree on URL validity
This should address #24589.
Note: to check that a URL is valid, we try to parse the url and if an exception is raised, we assume the url is not valid. Even though we catch the exception, Visual Studio might "force" the crash + break here: https://github.com/servo/servo/compare/master...paulrouget:url?expand=1#diff-4e059561062fe024a35522f60f7f14c1R116 - I'm not sure why. In VS, in the Exception Setting, we need to uncheck the Break When Thrown option to avoid that crash. It only happens for few urls and I'm unclear why.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24589 (GitHub issue number if applicable)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/layout_thread_2020')
0 files changed, 0 insertions, 0 deletions