diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-01-23 14:47:16 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-01-23 14:47:16 -0600 |
commit | 4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf (patch) | |
tree | 902cd39c3927348397baa27ccaf91bc3fd6d53fc /components/layout_thread/lib.rs | |
parent | 06aa339a1bf578d90f4c5a88877b579b67f33a56 (diff) | |
parent | 993e2f55eda267c758afd8bbc0e850232b4e7ba0 (diff) | |
download | servo-4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf.tar.gz servo-4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf.zip |
Auto merge of #19350 - gterzian:ignore_aborted_responses_in_caching, r=jdm
Ignore aborted responses in caching
<!-- Please describe your changes on the following line: -->
@jdm @KiChjang @Manishearth Follow up on https://github.com/servo/servo/pull/18676 and https://github.com/servo/servo/pull/19274 to ignore aborted responses in caching.
I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted.
I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing.
I also remove one unused import that slippled through previously.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350)
<!-- Reviewable:end -->
Diffstat (limited to 'components/layout_thread/lib.rs')
0 files changed, 0 insertions, 0 deletions