diff options
| author | bors-servo <infra@servo.org> | 2023-04-23 18:16:15 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-23 18:16:15 +0200 |
| commit | bf29f59adf5c7f3cd1081baa29f4c07e782374fa (patch) | |
| tree | 59e08d7a9c3d5f8791d4804d1c8d470d6773a9d6 /components/layout_2020/flow/construct.rs | |
| parent | 26f6c1c34babe933e41e7a6bbd864c9552fcb079 (diff) | |
| parent | 0f65bbd296961f3ba859274b1afd1b1dc08eb1d7 (diff) | |
| download | servo-bf29f59adf5c7f3cd1081baa29f4c07e782374fa.tar.gz servo-bf29f59adf5c7f3cd1081baa29f4c07e782374fa.zip | |
Auto merge of #29641 - CYBAI:fix-attr-checking, r=jdm
Throw HierarchyRequest error for attr node in pre-insertion
Based on Step 4 of https://dom.spec.whatwg.org/#concept-node-ensure-pre-insertion-validity, we should throw `HierarchyRequest` error when the node is not a [DocumentFragment](https://dom.spec.whatwg.org/#documentfragment), [DocumentType](https://dom.spec.whatwg.org/#documenttype), [Element](https://dom.spec.whatwg.org/#element), or [CharacterData](https://dom.spec.whatwg.org/#characterdata) [node](https://dom.spec.whatwg.org/#concept-node).
Thus, Attr is not one of them; we should throw an error in this case.
(I'm guessing it was a kind of typo in https://github.com/servo/servo/pull/25310 because we need to handle Attr with `unreachable` in line 1946)
So, with doing so, we can fix the CRASH in `/dom/attributes-are-nodes.html`.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)
- [x] There are tests for these changes
Diffstat (limited to 'components/layout_2020/flow/construct.rs')
0 files changed, 0 insertions, 0 deletions