aboutsummaryrefslogtreecommitdiffstats
path: root/components/layout
diff options
context:
space:
mode:
authorbors-servo <metajack+bors@gmail.com>2015-08-20 05:17:47 -0600
committerbors-servo <metajack+bors@gmail.com>2015-08-20 05:17:47 -0600
commit8f05447a7b1977f91fab753166fa428164a9307b (patch)
tree5a2bbed7d206d363d42a938fab45b6ae94820196 /components/layout
parent14b921ee29b1b5e46e8773836b5a31e85faabfd5 (diff)
parenta516042edbe22b4bdf270e51285cd344339002d7 (diff)
downloadservo-8f05447a7b1977f91fab753166fa428164a9307b.tar.gz
servo-8f05447a7b1977f91fab753166fa428164a9307b.zip
Auto merge of #7294 - servo:tick-animations-with-no-layout-root, r=glennw+Ms2ger
layout: Don't panic if `requestAnimationFrame()` is called before first layout. Closes #7115. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7294) <!-- Reviewable:end -->
Diffstat (limited to 'components/layout')
-rw-r--r--components/layout/layout_task.rs25
1 files changed, 17 insertions, 8 deletions
diff --git a/components/layout/layout_task.rs b/components/layout/layout_task.rs
index 4c982ec9661..010bbdd578f 100644
--- a/components/layout/layout_task.rs
+++ b/components/layout/layout_task.rs
@@ -1276,14 +1276,23 @@ impl LayoutTask {
&self.url,
reflow_info.goal);
- {
- // Perform an abbreviated style recalc that operates without access to the DOM.
- let mut root_flow = (*rw_data.root_flow.as_ref().unwrap()).clone();
- let animations = &*rw_data.running_animations;
- profile(time::ProfilerCategory::LayoutStyleRecalc,
- self.profiler_metadata(),
- self.time_profiler_chan.clone(),
- || animation::recalc_style_for_animations(root_flow.deref_mut(), animations));
+ match rw_data.root_flow.as_ref() {
+ None => {
+ // We haven't performed a single layout yet! Do nothing.
+ return
+ }
+ Some(ref root_flow) => {
+ // Perform an abbreviated style recalc that operates without access to the DOM.
+ let mut root_flow = (*root_flow).clone();
+ let animations = &*rw_data.running_animations;
+ profile(time::ProfilerCategory::LayoutStyleRecalc,
+ self.profiler_metadata(),
+ self.time_profiler_chan.clone(),
+ || {
+ animation::recalc_style_for_animations(root_flow.deref_mut(),
+ animations)
+ });
+ }
}
self.perform_post_style_recalc_layout_passes(&reflow_info,