diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-08-03 05:50:18 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-08-03 05:50:18 -0500 |
| commit | 452268eca9862e0e150ce3bf828a157263d33341 (patch) | |
| tree | c451ea9e20d33d4d3227bee58d9c9096274c61b5 /components/layout/traversal.rs | |
| parent | 24b2cd89c124457e837bcde7cc9101747b96e9d4 (diff) | |
| parent | 6c5cf5e2ec269bb06fa4a55fe2c0448e97de1361 (diff) | |
| download | servo-452268eca9862e0e150ce3bf828a157263d33341.tar.gz servo-452268eca9862e0e150ce3bf828a157263d33341.zip | |
Auto merge of #17959 - emilio:no-moar-parent, r=heycam
style: Move nsStyleContext::mParent to GeckoStyleContext.
Unfortunately this means that we lose the NS_STYLE_INHERIT_BIT optimization to
avoid posting changes if we had not requested the struct. In practice, I'm not
sure this optimization matters much, though, and we already compare all the
structs anyway.
We _could_ keep a weak parent pointer from the text style if needed, given we're
going to keep alive the text style at least until the parent style context goes
away, so should be safe, but I don't think the extra churn is worth it, to be
honest. Happy to do so as part of bug 1368290 if you think it's worth it.
Bug: 1385896
Reviewed-by: heycam
MozReview-Commit-ID: ka6tNwf4Ke
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17959)
<!-- Reviewable:end -->
Diffstat (limited to 'components/layout/traversal.rs')
0 files changed, 0 insertions, 0 deletions