diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-02-11 17:46:31 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-02-11 17:46:31 -0500 |
commit | baac1e2c69d3b6e840ced2be4b5e03bb39bd40d5 (patch) | |
tree | 6772b2473dd2a11c13dd4ff8759510acdf165d09 /components/layout/table_row.rs | |
parent | e89e78d401c785cd11189c5d448a6248165c5a83 (diff) | |
parent | 8902aa93e483810f688a6e3999110adb891bc9c3 (diff) | |
download | servo-baac1e2c69d3b6e840ced2be4b5e03bb39bd40d5.tar.gz servo-baac1e2c69d3b6e840ced2be4b5e03bb39bd40d5.zip |
Auto merge of #25728 - rib:wip/rib/windows-build-fixes, r=jdm
Wip/rib/windows build fixes
These were minor changes I needed to make to build Servo on Windows based on following the existing instructions. In particular:
Even though I have C:\Python27 with python.exe in my PATH the build failed at some point when it failed to find python27.exe and I found that explicitly setting the PYTHON2 environment variable resolved this failure.
The end of the build failed to package MSVC redistributable DLLs and that was simply because I have a version (142) installed that wasn't checked for by build_commands.py.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix builds on Windows if you have version 142 MSVC redistributable DLLs and if you don't have a python2.7exe or python27.exe in your PATH.
<!-- Either: -->
- [x] These changes do not require tests because they don't change any servo code
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/layout/table_row.rs')
0 files changed, 0 insertions, 0 deletions