diff options
author | Simon Sapin <simon.sapin@exyr.org> | 2019-09-29 23:11:40 +0200 |
---|---|---|
committer | Simon Sapin <simon.sapin@exyr.org> | 2019-09-29 23:11:40 +0200 |
commit | 47c269360cebba4857433bc2ef4dead70b42a01a (patch) | |
tree | 9351fb3fb7afaab852122b3aec4228c827568e54 /components/dom_struct/lib.rs | |
parent | 086e06b28b7722b3e268b846e6c507f1060a2931 (diff) | |
download | servo-47c269360cebba4857433bc2ef4dead70b42a01a.tar.gz servo-47c269360cebba4857433bc2ef4dead70b42a01a.zip |
Remove redundant webidl_must_inherit compiler plugin lint
At first I was considering moving it to a procedural macro
(source-level information should be sufficient),
and started by trying to reproduce the error case
by changing `htmldivelement.rs` to use `Element` instead of `HTMLElement`
as the first field.
The output was:
```rust
error[E0308]: mismatched types
--> /home/simon/servo2/target/debug/build/script-4caa244faca7d10f/out/Bindings/HTMLDivElementBinding.rs:665:31
|
665 | let _: &HTMLElement = self.as_parent();
| ^^^^^^^^^^^^^^^^ expected struct `dom::htmlelement::HTMLElement`, found struct `dom::element::Element`
|
= note: expected type `&dom::htmlelement::HTMLElement`
found type `&dom::element::Element`
```
This line number is inside a generated method called `__assert_parent_type`.
As far as I can tell, any case where this lint would error is already caught
by such methods. The lint is therefore redundant and can safely be removed.
Diffstat (limited to 'components/dom_struct/lib.rs')
-rw-r--r-- | components/dom_struct/lib.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/components/dom_struct/lib.rs b/components/dom_struct/lib.rs index f316a6f22bb..e7b2b290ce5 100644 --- a/components/dom_struct/lib.rs +++ b/components/dom_struct/lib.rs @@ -19,7 +19,6 @@ pub fn dom_struct(args: TokenStream, input: TokenStream) -> TokenStream { #[derive(DenyPublicFields, DomObject, JSTraceable, MallocSizeOf)] #[must_root] #[repr(C)] - #[webidl] }; // Work around https://github.com/rust-lang/rust/issues/46489 |