diff options
| author | Mukilan Thiyagarajan <me@mukilan.in> | 2023-04-29 19:41:41 +0200 |
|---|---|---|
| committer | Mukilan Thiyagarajan <me@mukilan.in> | 2023-05-12 00:14:38 +0530 |
| commit | 8cfb19a8fba80a809af028223dd3a58d38123d02 (patch) | |
| tree | ef051de063464259172ea52acfbf0a1d67dceb18 /README.md | |
| parent | 425b0fe641e16083507c459041ff5dd19256ed7c (diff) | |
| download | servo-8cfb19a8fba80a809af028223dd3a58d38123d02.tar.gz servo-8cfb19a8fba80a809af028223dd3a58d38123d02.zip | |
Consume official GStreamer binaries on MacOS
This PR re-enables support for the gstreamer mediastack
in macOS by consuming the official binary '.pkg' files
from gstreamer.freedesktop.org
To maintain symmetry with other platforms, the '.pkg'
files are uploaded to servo-build-deps and fetched from
there using the new script 'etc/install_macos_gstreamer.sh'.
Unlike the Homebrew version, the official GStreamer is
distributed as a 'relocatable' framework i.e the dylibs all
have @rpath-relative install names and also link to other
dylibs using @rpath relative path. To address this difference
the 'servo' binary needs to be patched with 'install_name_tool'
to add an LC_RPATH command that sets the relative paths
that the dynamic linker should search when trying to satify
dependencies. In Servo's case, this will be a path relative to
the 'servo' binary itself i.e '@executable_path/lib/'
The additional 'lib' is due to a flaw in the gstreamer
packaging where the install names of some of the dylibs
have the prefix '@rpath/lib' and some of them just have '@rpath'.
This PR also fixes a couple of issues present in the
`mach build` process on MacOS:
1. `mach build` process was not copying transitive dependencies
of servo binary but only the first level dylibs
2. `mach build` process didn't patch the links to dylibs
in servo binary (and dependencies). This meant though
(some) dylibs were copied to local path, the binary
still loaded the dylibs from system GStreamer installation
i.e homebrew instead of the copieds dylibs
The build and runtime dependencies in etc/homebrew/Brewfile
and etc/homebrew/Brewfile-build have also been removed in This
PR.
Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
Diffstat (limited to 'README.md')
| -rw-r--r-- | README.md | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/README.md b/README.md index 771ae02f3fd..5e85abaf920 100644 --- a/README.md +++ b/README.md @@ -58,8 +58,7 @@ NOTE: run these steps after you've cloned the project locally. ``` sh cd servo -brew bundle install --file=etc/homebrew/Brewfile -brew bundle install --file=etc/homebrew/Brewfile-build +bash etc/install_macos_gstreamer.sh pip install virtualenv ``` |