diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-02-11 17:46:31 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-11 17:46:31 -0500 |
| commit | baac1e2c69d3b6e840ced2be4b5e03bb39bd40d5 (patch) | |
| tree | 6772b2473dd2a11c13dd4ff8759510acdf165d09 /README.md | |
| parent | e89e78d401c785cd11189c5d448a6248165c5a83 (diff) | |
| parent | 8902aa93e483810f688a6e3999110adb891bc9c3 (diff) | |
| download | servo-baac1e2c69d3b6e840ced2be4b5e03bb39bd40d5.tar.gz servo-baac1e2c69d3b6e840ced2be4b5e03bb39bd40d5.zip | |
Auto merge of #25728 - rib:wip/rib/windows-build-fixes, r=jdm
Wip/rib/windows build fixes
These were minor changes I needed to make to build Servo on Windows based on following the existing instructions. In particular:
Even though I have C:\Python27 with python.exe in my PATH the build failed at some point when it failed to find python27.exe and I found that explicitly setting the PYTHON2 environment variable resolved this failure.
The end of the build failed to package MSVC redistributable DLLs and that was simply because I have a version (142) installed that wasn't checked for by build_commands.py.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix builds on Windows if you have version 142 MSVC redistributable DLLs and if you don't have a python2.7exe or python27.exe in your PATH.
<!-- Either: -->
- [x] These changes do not require tests because they don't change any servo code
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'README.md')
| -rw-r--r-- | README.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/README.md b/README.md index 1553e0494b6..aecf062357d 100644 --- a/README.md +++ b/README.md @@ -194,6 +194,11 @@ export LIBCLANG_PATH=$(llvm-config --prefix)/lib64 You should change the installation to install the "Add python.exe to Path" feature. +You will also need to set the `PYTHON2` environment variable, e.g., to 'C:\Python27\python.exe' by doing: +``` +setx PYTHON2 "C:\Python27\python.exe" /m +``` + 2. Install Python 3.7 for Windows (https://www.python.org/downloads/release/python-374/). The Windows x86-64 MSI installer is fine. This is required in order to build the JavaScript engine, SpiderMonkey. You will also need to set the `PYTHON3` environment variable, e.g., to 'C:\Python37\python.exe' by doing: |