aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Jeffrey <ajeffrey@mozilla.com>2017-01-27 14:03:18 -0600
committerAlan Jeffrey <ajeffrey@mozilla.com>2017-01-28 21:48:07 -0600
commitfc67878edf93125eb32b245dcaf177c61c47a033 (patch)
tree2d83c6b68419a6ddf2fa6b94efcf506fe05ceb8f
parentec12b7665b5cf35b13932a7c17901ffb8e73b5ee (diff)
downloadservo-fc67878edf93125eb32b245dcaf177c61c47a033.tar.gz
servo-fc67878edf93125eb32b245dcaf177c61c47a033.zip
Remove warnings about unnecessary mutability.
-rw-r--r--components/script/dom/extendablemessageevent.rs6
-rw-r--r--components/script/dom/imagedata.rs2
-rw-r--r--components/script/dom/messageevent.rs6
-rw-r--r--components/script/dom/vreyeparameters.rs2
-rw-r--r--components/script/dom/vrframedata.rs2
-rw-r--r--components/script/dom/vrpose.rs2
-rw-r--r--components/script/dom/vrstageparameters.rs2
7 files changed, 9 insertions, 13 deletions
diff --git a/components/script/dom/extendablemessageevent.rs b/components/script/dom/extendablemessageevent.rs
index 8f156a8f4d3..a7ee5f797af 100644
--- a/components/script/dom/extendablemessageevent.rs
+++ b/components/script/dom/extendablemessageevent.rs
@@ -17,7 +17,6 @@ use dom::serviceworkerglobalscope::ServiceWorkerGlobalScope;
use js::jsapi::{HandleValue, Heap, JSContext};
use js::jsval::JSVal;
use servo_atoms::Atom;
-use std::default::Default;
#[dom_struct]
pub struct ExtendableMessageEvent {
@@ -32,13 +31,12 @@ impl ExtendableMessageEvent {
bubbles: bool, cancelable: bool,
data: HandleValue, origin: DOMString, lastEventId: DOMString)
-> Root<ExtendableMessageEvent> {
- let mut ev = box ExtendableMessageEvent {
+ let ev = box ExtendableMessageEvent {
event: ExtendableEvent::new_inherited(),
- data: Heap::default(),
+ data: Heap::new(data.get()),
origin: origin,
lastEventId: lastEventId,
};
- ev.data.set(data.get());
let ev = reflect_dom_object(ev, global, ExtendableMessageEventBinding::Wrap);
{
let event = ev.upcast::<Event>();
diff --git a/components/script/dom/imagedata.rs b/components/script/dom/imagedata.rs
index 4cc6f3fa235..6edf2e309b2 100644
--- a/components/script/dom/imagedata.rs
+++ b/components/script/dom/imagedata.rs
@@ -27,7 +27,7 @@ pub struct ImageData {
impl ImageData {
#[allow(unsafe_code)]
pub fn new(global: &GlobalScope, width: u32, height: u32, data: Option<Vec<u8>>) -> Root<ImageData> {
- let mut imagedata = box ImageData {
+ let imagedata = box ImageData {
reflector_: Reflector::new(),
width: width,
height: height,
diff --git a/components/script/dom/messageevent.rs b/components/script/dom/messageevent.rs
index b457461723c..5b36b14f6ce 100644
--- a/components/script/dom/messageevent.rs
+++ b/components/script/dom/messageevent.rs
@@ -16,7 +16,6 @@ use dom::globalscope::GlobalScope;
use js::jsapi::{HandleValue, Heap, JSContext};
use js::jsval::JSVal;
use servo_atoms::Atom;
-use std::default::Default;
#[dom_struct]
pub struct MessageEvent {
@@ -38,13 +37,12 @@ impl MessageEvent {
data: HandleValue,
origin: DOMString,
lastEventId: DOMString) -> Root<MessageEvent> {
- let mut ev = box MessageEvent {
+ let ev = box MessageEvent {
event: Event::new_inherited(),
- data: Heap::default(),
+ data: Heap::new(data.get()),
origin: origin,
lastEventId: lastEventId,
};
- ev.data.set(data.get());
reflect_dom_object(ev, global, MessageEventBinding::Wrap)
}
diff --git a/components/script/dom/vreyeparameters.rs b/components/script/dom/vreyeparameters.rs
index 9a5e2066e2c..ca544f03456 100644
--- a/components/script/dom/vreyeparameters.rs
+++ b/components/script/dom/vreyeparameters.rs
@@ -31,7 +31,7 @@ impl VREyeParameters {
#[allow(unrooted_must_root)]
fn new_inherited(parameters: WebVREyeParameters, global: &GlobalScope) -> VREyeParameters {
let fov = VRFieldOfView::new(&global, parameters.field_of_view.clone());
- let mut result = VREyeParameters {
+ let result = VREyeParameters {
reflector_: Reflector::new(),
parameters: DOMRefCell::new(parameters),
offset: Heap::default(),
diff --git a/components/script/dom/vrframedata.rs b/components/script/dom/vrframedata.rs
index 4c1d14d66a6..14cbe9bdbab 100644
--- a/components/script/dom/vrframedata.rs
+++ b/components/script/dom/vrframedata.rs
@@ -39,7 +39,7 @@ impl VRFrameData {
0.0, 0.0, 0.0, 1.0f32];
let pose = VRPose::new(&global, &Default::default());
- let mut framedata = VRFrameData {
+ let framedata = VRFrameData {
reflector_: Reflector::new(),
left_proj: Heap::default(),
left_view: Heap::default(),
diff --git a/components/script/dom/vrpose.rs b/components/script/dom/vrpose.rs
index a6cb09d96bf..cbf56c5cc26 100644
--- a/components/script/dom/vrpose.rs
+++ b/components/script/dom/vrpose.rs
@@ -29,7 +29,7 @@ pub struct VRPose {
unsafe fn update_or_create_typed_array(cx: *mut JSContext,
src: Option<&[f32]>,
dst: &DOMRefCell<Heap<*mut JSObject>>) {
- let mut dst = dst.borrow_mut();
+ let dst = dst.borrow();
match src {
Some(ref data) => {
if dst.get().is_null() {
diff --git a/components/script/dom/vrstageparameters.rs b/components/script/dom/vrstageparameters.rs
index ac3636aac91..481bc027271 100644
--- a/components/script/dom/vrstageparameters.rs
+++ b/components/script/dom/vrstageparameters.rs
@@ -28,7 +28,7 @@ impl VRStageParameters {
#[allow(unsafe_code)]
#[allow(unrooted_must_root)]
fn new_inherited(parameters: WebVRStageParameters, global: &GlobalScope) -> VRStageParameters {
- let mut stage = VRStageParameters {
+ let stage = VRStageParameters {
reflector_: Reflector::new(),
parameters: DOMRefCell::new(parameters),
transform: Heap::default()