aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFernando Jiménez Moreno <ferjmoreno@gmail.com>2019-06-11 11:53:46 +0200
committerFernando Jiménez Moreno <ferjmoreno@gmail.com>2019-07-22 17:40:16 +0200
commitf8ae394cadb28958e52ae941bc3a89f4ea7fb4b5 (patch)
tree41b6f851e8337971846eaa7148ba711e5fe68375
parent5aba6d5bbbd654979730ab2a74d6956fdee5a151 (diff)
downloadservo-f8ae394cadb28958e52ae941bc3a89f4ea7fb4b5.tar.gz
servo-f8ae394cadb28958e52ae941bc3a89f4ea7fb4b5.zip
Remove extra hash-map lookup unregistering media controls
-rw-r--r--components/script/dom/document.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs
index fea12fc6905..20f29de2f42 100644
--- a/components/script/dom/document.rs
+++ b/components/script/dom/document.rs
@@ -2475,7 +2475,8 @@ impl Document {
}
pub fn unregister_media_controls(&self, id: &str) {
- if let Some(media_controls) = self.media_controls.borrow().get(id) {
+ if let Some(ref media_controls) = self.media_controls.borrow_mut().remove(id) {
+ let media_controls = DomRoot::from_ref(&**media_controls);
media_controls.Host().detach_shadow();
media_controls
.upcast::<Node>()
@@ -2483,7 +2484,6 @@ impl Document {
} else {
debug_assert!(false, "Trying to unregister unknown media controls");
}
- self.media_controls.borrow_mut().remove(id);
}
}