diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-03-13 07:01:52 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-03-13 07:01:52 -0700 |
commit | d70c1e53ae06d2dc2216c0d59709b12396378be7 (patch) | |
tree | 62416d27b6bb8358c5f5d9e14be1d0cde907f190 | |
parent | cc9fb0ba59181d478eabb64e942b9342a4879a73 (diff) | |
parent | 5b25cb33450e13acd6160af81cd462d3b7778538 (diff) | |
download | servo-d70c1e53ae06d2dc2216c0d59709b12396378be7.tar.gz servo-d70c1e53ae06d2dc2216c0d59709b12396378be7.zip |
Auto merge of #15874 - sendilkumarn:user-script, r=nox
apply user scripts correctly
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15082
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15874)
<!-- Reviewable:end -->
-rw-r--r-- | components/script/dom/userscripts.rs | 26 |
1 files changed, 12 insertions, 14 deletions
diff --git a/components/script/dom/userscripts.rs b/components/script/dom/userscripts.rs index 66758afaa98..fd5ae5f023e 100644 --- a/components/script/dom/userscripts.rs +++ b/components/script/dom/userscripts.rs @@ -2,25 +2,25 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use dom::bindings::codegen::Bindings::DocumentBinding::DocumentMethods; -use dom::bindings::codegen::Bindings::NodeBinding::NodeMethods; use dom::bindings::inheritance::Castable; -use dom::bindings::js::RootedReference; -use dom::bindings::str::DOMString; +use dom::globalscope::GlobalScope; use dom::htmlheadelement::HTMLHeadElement; use dom::node::Node; +use js::jsval::UndefinedValue; use servo_config::opts; use servo_config::resource_files::resources_dir_path; -use std::borrow::ToOwned; -use std::fs::read_dir; +use std::fs::{File, read_dir}; +use std::io::Read; use std::path::PathBuf; pub fn load_script(head: &HTMLHeadElement) { if let Some(ref path_str) = opts::get().userscripts { let node = head.upcast::<Node>(); - let first_child = node.GetFirstChild(); let doc = node.owner_doc(); + let win = doc.window(); + let cx = win.get_cx(); + rooted!(in(cx) let mut rval = UndefinedValue()); let path = if &**path_str == "" { if let Ok(mut p) = resources_dir_path() { @@ -40,13 +40,11 @@ pub fn load_script(head: &HTMLHeadElement) { files.sort(); for file in files { - let name = match file.into_os_string().into_string() { - Ok(ref s) if s.ends_with(".js") => "file://".to_owned() + &s[..], - _ => continue - }; - let new_script = doc.CreateElement(DOMString::from("script")).unwrap(); - new_script.set_string_attribute(&local_name!("src"), DOMString::from(name)); - node.InsertBefore(new_script.upcast(), first_child.r()).unwrap(); + let mut f = File::open(&file).unwrap(); + let mut contents = vec![]; + f.read_to_end(&mut contents).unwrap(); + let script_text = String::from_utf8_lossy(&contents); + win.upcast::<GlobalScope>().evaluate_js_on_global_with_result(&script_text, rval.handle_mut()); } } } |