aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2019-03-14 15:14:44 -0400
committerGitHub <noreply@github.com>2019-03-14 15:14:44 -0400
commitbc03d321429799321be238067f11de4ca6c7e90f (patch)
tree467fd5f5a250eeabda9a84bf915653e4d4dde780
parent2cd454f4f8187911da829ac2f28e6807b31e2a4b (diff)
parentb17343a0ffbae0621dcedefb0258a40860aeb8d5 (diff)
downloadservo-bc03d321429799321be238067f11de4ca6c7e90f.tar.gz
servo-bc03d321429799321be238067f11de4ca6c7e90f.zip
Auto merge of #23016 - pngai:remove-on-prefix, r=jdm
Remove 'on' prefix from event handler macros <!-- Please describe your changes on the following line: --> Remove 'on' prefix from event handler macros --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22516 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23016) <!-- Reviewable:end -->
-rw-r--r--components/script/dom/permissionstatus.rs2
-rw-r--r--components/script/dom/texttrack.rs2
-rw-r--r--components/script/dom/texttrackcue.rs4
-rw-r--r--components/script/dom/texttracklist.rs6
-rw-r--r--tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrack/oncuechange.html.ini4
-rw-r--r--tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onaddtrack.html.ini4
-rw-r--r--tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onremovetrack.html.ini4
7 files changed, 7 insertions, 19 deletions
diff --git a/components/script/dom/permissionstatus.rs b/components/script/dom/permissionstatus.rs
index 503b4031b38..80a6e347bd2 100644
--- a/components/script/dom/permissionstatus.rs
+++ b/components/script/dom/permissionstatus.rs
@@ -56,7 +56,7 @@ impl PermissionStatusMethods for PermissionStatus {
}
// https://w3c.github.io/permissions/#dom-permissionstatus-onchange
- event_handler!(onchange, GetOnchange, SetOnchange);
+ event_handler!(change, GetOnchange, SetOnchange);
}
impl Display for PermissionName {
diff --git a/components/script/dom/texttrack.rs b/components/script/dom/texttrack.rs
index 678bfb3a47b..88c4859e05e 100644
--- a/components/script/dom/texttrack.rs
+++ b/components/script/dom/texttrack.rs
@@ -148,5 +148,5 @@ impl TextTrackMethods for TextTrack {
}
// https://html.spec.whatwg.org/multipage/#handler-texttrack-oncuechange
- event_handler!(oncuechange, GetOncuechange, SetOncuechange);
+ event_handler!(cuechange, GetOncuechange, SetOncuechange);
}
diff --git a/components/script/dom/texttrackcue.rs b/components/script/dom/texttrackcue.rs
index 6faf698921f..ce55cdf3259 100644
--- a/components/script/dom/texttrackcue.rs
+++ b/components/script/dom/texttrackcue.rs
@@ -104,8 +104,8 @@ impl TextTrackCueMethods for TextTrackCue {
}
// https://html.spec.whatwg.org/multipage/#handler-texttrackcue-onenter
- event_handler!(onenter, GetOnenter, SetOnenter);
+ event_handler!(enter, GetOnenter, SetOnenter);
// https://html.spec.whatwg.org/multipage/#handler-texttrackcue-onexit
- event_handler!(onexit, GetOnexit, SetOnexit);
+ event_handler!(exit, GetOnexit, SetOnexit);
}
diff --git a/components/script/dom/texttracklist.rs b/components/script/dom/texttracklist.rs
index df5e2d630ac..f6f9037902e 100644
--- a/components/script/dom/texttracklist.rs
+++ b/components/script/dom/texttracklist.rs
@@ -130,11 +130,11 @@ impl TextTrackListMethods for TextTrackList {
}
// https://html.spec.whatwg.org/multipage/#handler-texttracklist-onchange
- event_handler!(onchange, GetOnchange, SetOnchange);
+ event_handler!(change, GetOnchange, SetOnchange);
// https://html.spec.whatwg.org/multipage/#handler-texttracklist-onaddtrack
- event_handler!(onaddtrack, GetOnaddtrack, SetOnaddtrack);
+ event_handler!(addtrack, GetOnaddtrack, SetOnaddtrack);
// https://html.spec.whatwg.org/multipage/#handler-texttracklist-onremovetrack
- event_handler!(onremovetrack, GetOnremovetrack, SetOnremovetrack);
+ event_handler!(removetrack, GetOnremovetrack, SetOnremovetrack);
}
diff --git a/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrack/oncuechange.html.ini b/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrack/oncuechange.html.ini
deleted file mode 100644
index 30d0306190f..00000000000
--- a/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrack/oncuechange.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[oncuechange.html]
- [TextTrack.oncuechange]
- expected: FAIL
-
diff --git a/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onaddtrack.html.ini b/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onaddtrack.html.ini
deleted file mode 100644
index bb3a5e99a83..00000000000
--- a/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onaddtrack.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[onaddtrack.html]
- [TextTrackList.onaddtrack]
- expected: FAIL
-
diff --git a/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onremovetrack.html.ini b/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onremovetrack.html.ini
deleted file mode 100644
index ae82873b6a8..00000000000
--- a/tests/wpt/metadata/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/onremovetrack.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[onremovetrack.html]
- [TextTrackList.onremovetrack]
- expected: FAIL
-