script: Fix code generation for named getters.

Fixes part of #18535

3 files changed, 68 insertions, 6 deletions

diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py
index 7f97868a378..0ad87747a12 100644
--- a/components/script/dom/bindings/codegen/CodegenRust.py
+++ b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -4938,8 +4938,6 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
             set += ("if RUST_JSID_IS_STRING(id) {\n" +
                     CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +
                     "    return (*opresult).succeed();\n" +
-                    "} else {\n" +
-                    "    return false;\n" +
                     "}\n")
         else:
             set += ("if RUST_JSID_IS_STRING(id) {\n" +
@@ -4948,7 +4946,7 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
                     "        return (*opresult).failNoNamedSetter();\n"
                     "    }\n"
                     "}\n")
-            set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args)
+        set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args)
         return set
 
     def definition_body(self):
diff --git a/tests/wpt/metadata/webstorage/storage_setitem.html.ini b/tests/wpt/metadata/webstorage/storage_setitem.html.ini
index 0a0f43019b2..ca08ab7a750 100644
--- a/tests/wpt/metadata/webstorage/storage_setitem.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_setitem.html.ini
@@ -1,6 +1,5 @@
 [storage_setitem.html]
   type: testharness
-  expected: TIMEOUT
   [localStorage[\] = "�"]
     expected: FAIL
     bug: https://github.com/servo/servo/issues/6564
@@ -14,6 +13,72 @@
     bug: https://github.com/servo/servo/issues/6564
 
   [localStorage["0"\]]
-    expected: TIMEOUT
+    expected: FAIL
     bug: https://github.com/servo/servo/issues/10686
 
+  [localStorage["1"\]]
+    expected: FAIL
+
+  [localStorage["2"\]]
+    expected: FAIL
+
+  [localStorage["3"\]]
+    expected: FAIL
+
+  [localStorage["4"\]]
+    expected: FAIL
+
+  [localStorage["5"\]]
+    expected: FAIL
+
+  [localStorage["6"\]]
+    expected: FAIL
+
+  [localStorage["7"\]]
+    expected: FAIL
+
+  [localStorage["8"\]]
+    expected: FAIL
+
+  [localStorage["9"\]]
+    expected: FAIL
+
+  [sessionStorage[\] = "�"]
+    expected: FAIL
+
+  [sessionStorage[\] = "�a"]
+    expected: FAIL
+
+  [sessionStorage[\] = "a�"]
+    expected: FAIL
+
+  [sessionStorage["0"\]]
+    expected: FAIL
+
+  [sessionStorage["1"\]]
+    expected: FAIL
+
+  [sessionStorage["2"\]]
+    expected: FAIL
+
+  [sessionStorage["3"\]]
+    expected: FAIL
+
+  [sessionStorage["4"\]]
+    expected: FAIL
+
+  [sessionStorage["5"\]]
+    expected: FAIL
+
+  [sessionStorage["6"\]]
+    expected: FAIL
+
+  [sessionStorage["7"\]]
+    expected: FAIL
+
+  [sessionStorage["8"\]]
+    expected: FAIL
+
+  [sessionStorage["9"\]]
+    expected: FAIL
+
diff --git a/tests/wpt/mozilla/meta/css/css-position-3/position-sticky-nested-bottom.html.ini b/tests/wpt/mozilla/meta/css/css-position-3/position-sticky-nested-bottom.html.ini
index 54aa5d5dac5..796caade081 100644
--- a/tests/wpt/mozilla/meta/css/css-position-3/position-sticky-nested-bottom.html.ini
+++ b/tests/wpt/mozilla/meta/css/css-position-3/position-sticky-nested-bottom.html.ini
@@ -5,4 +5,3 @@
   [Untitled]
     expected: FAIL
 
-