aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorManish Goregaokar <manishsmail@gmail.com>2017-09-24 00:47:29 -0700
committerManish Goregaokar <manishsmail@gmail.com>2017-09-24 00:47:54 -0700
commitb238eae66cdff14c5868290b69616ef39e1f15cb (patch)
tree24b0fe1aab3905ad99cc8698f8aad785927878d0
parentce7d82e9c49ce84acebcf5e3a28fc74f5b97fead (diff)
downloadservo-b238eae66cdff14c5868290b69616ef39e1f15cb.tar.gz
servo-b238eae66cdff14c5868290b69616ef39e1f15cb.zip
Add FIXME for font-size animated value
-rw-r--r--components/style/values/computed/font.rs4
-rw-r--r--components/style/values/computed/length.rs2
2 files changed, 5 insertions, 1 deletions
diff --git a/components/style/values/computed/font.rs b/components/style/values/computed/font.rs
index 8edca57bda9..6d0571b8c0c 100644
--- a/components/style/values/computed/font.rs
+++ b/components/style/values/computed/font.rs
@@ -76,6 +76,10 @@ impl ToCss for FontSize {
}
}
+/// XXXManishearth it might be better to
+/// animate this as computed, however this complicates
+/// clamping and might not be the right thing to do.
+/// We should figure it out.
impl ToAnimatedValue for FontSize {
type AnimatedValue = NonNegativeLength;
diff --git a/components/style/values/computed/length.rs b/components/style/values/computed/length.rs
index c6cea9429c8..ea55f8bd4e4 100644
--- a/components/style/values/computed/length.rs
+++ b/components/style/values/computed/length.rs
@@ -792,7 +792,7 @@ impl NonNegativeLength {
}
#[inline]
- /// Ensures it is positive
+ /// Ensures it is non negative
pub fn clamp(self) -> Self {
if (self.0).0 < 0. {
Self::zero()