aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2016-01-22 22:53:53 +0530
committerbors-servo <lbergstrom+bors@mozilla.com>2016-01-22 22:53:53 +0530
commita9147275413a1a83ab737f0188a283b2a7dedb85 (patch)
treed8c4825ba9a046fcea00a2315b465ebc29f94b91
parent1c6fb0f04e0cf305f4e1f75371be84944b1e5518 (diff)
parent75d258f86637a30522dd5e09e9d9f1a080f8b036 (diff)
downloadservo-a9147275413a1a83ab737f0188a283b2a7dedb85.tar.gz
servo-a9147275413a1a83ab737f0188a283b2a7dedb85.zip
Auto merge of #9404 - shssoichiro:htmlformelementlength, r=nox
Update HTMLFormElement.length to be of type unsigned long Fixes #9402 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9404) <!-- Reviewable:end -->
-rw-r--r--components/script/dom/htmlformelement.rs4
-rw-r--r--components/script/dom/webidls/HTMLFormElement.webidl2
-rw-r--r--tests/wpt/web-platform-tests/html/dom/interfaces.html2
3 files changed, 4 insertions, 4 deletions
diff --git a/components/script/dom/htmlformelement.rs b/components/script/dom/htmlformelement.rs
index 0922902778a..32838399a93 100644
--- a/components/script/dom/htmlformelement.rs
+++ b/components/script/dom/htmlformelement.rs
@@ -205,8 +205,8 @@ impl HTMLFormElementMethods for HTMLFormElement {
}
// https://html.spec.whatwg.org/multipage/#dom-form-length
- fn Length(&self) -> i32 {
- self.Elements().Length() as i32
+ fn Length(&self) -> u32 {
+ self.Elements().Length() as u32
}
}
diff --git a/components/script/dom/webidls/HTMLFormElement.webidl b/components/script/dom/webidls/HTMLFormElement.webidl
index d97de7dd22d..eebe0b52c62 100644
--- a/components/script/dom/webidls/HTMLFormElement.webidl
+++ b/components/script/dom/webidls/HTMLFormElement.webidl
@@ -17,7 +17,7 @@ interface HTMLFormElement : HTMLElement {
attribute DOMString target;
[SameObject] readonly attribute HTMLFormControlsCollection elements;
- readonly attribute long length;
+ readonly attribute unsigned long length;
//getter Element (unsigned long index);
//getter (RadioNodeList or Element) (DOMString name);
diff --git a/tests/wpt/web-platform-tests/html/dom/interfaces.html b/tests/wpt/web-platform-tests/html/dom/interfaces.html
index f76d0ce38a7..8eb7df805fb 100644
--- a/tests/wpt/web-platform-tests/html/dom/interfaces.html
+++ b/tests/wpt/web-platform-tests/html/dom/interfaces.html
@@ -1591,7 +1591,7 @@ interface HTMLFormElement : HTMLElement {
attribute DOMString target;
readonly attribute HTMLFormControlsCollection elements;
- readonly attribute long length;
+ readonly attribute unsigned long length;
getter Element (unsigned long index);
getter (RadioNodeList or Element) (DOMString name);