aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2019-11-07 02:38:26 -0500
committerGitHub <noreply@github.com>2019-11-07 02:38:26 -0500
commita33d493a4ff6f8a629a9b82202c49c41ecbefa49 (patch)
tree5f651d733950a07d2ff44a1a5f99f56bc6baabc0
parent64560ec0b66066e06050b090d9fe7b281897516d (diff)
parentd779573fe08e62032b7f73c75546103df445b60e (diff)
downloadservo-a33d493a4ff6f8a629a9b82202c49c41ecbefa49.tar.gz
servo-a33d493a4ff6f8a629a9b82202c49c41ecbefa49.zip
Auto merge of #24672 - paulrouget:24400, r=jdm
Print an error if Glutin port needs to manage a new tab When a tab needs to be created because the user clicks on a link with a `target=…` attribute, the Glutin port just ignores it, creating weird behaviors. We should at least print an error.
-rw-r--r--ports/glutin/browser.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/ports/glutin/browser.rs b/ports/glutin/browser.rs
index 7255390fdf6..e3da4d13d61 100644
--- a/ports/glutin/browser.rs
+++ b/ports/glutin/browser.rs
@@ -346,6 +346,8 @@ where
self.browsers.push(new_browser_id);
if self.browser_id.is_none() {
self.browser_id = Some(new_browser_id);
+ } else {
+ error!("Multiple top level browsing contexts not supported yet.");
}
self.event_queue
.push(WindowEvent::SelectBrowser(new_browser_id));