aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <servo-ops@mozilla.com>2020-05-10 08:40:07 -0400
committerGitHub <noreply@github.com>2020-05-10 08:40:07 -0400
commit4d541e8e381e3b3388dd1d1378d147e22197b11d (patch)
tree13a086974ed1cc80d6cca79b41202cd1a1f88f66
parentd20b7b96261774a0e841d07a5aa805b6b2ea31a1 (diff)
parent4b4ea6483ac2181b87421c75e8f1822b133dc24c (diff)
downloadservo-4d541e8e381e3b3388dd1d1378d147e22197b11d.tar.gz
servo-4d541e8e381e3b3388dd1d1378d147e22197b11d.zip
Auto merge of #26481 - mrobinson:remove-fixme, r=jdm
Remove a TODO from the implementation of getComputedStyle The spec is now clear that disconnected elements shouldn't return a style. Closes #6860. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #6860 - [x] These changes do not require tests because they just update a comment. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
-rw-r--r--components/script/dom/cssstyledeclaration.rs2
1 files changed, 0 insertions, 2 deletions
diff --git a/components/script/dom/cssstyledeclaration.rs b/components/script/dom/cssstyledeclaration.rs
index 01e41d3f0ef..ba7112b8899 100644
--- a/components/script/dom/cssstyledeclaration.rs
+++ b/components/script/dom/cssstyledeclaration.rs
@@ -242,8 +242,6 @@ impl CSSStyleDeclaration {
CSSStyleOwner::Element(ref el) => {
let node = el.upcast::<Node>();
if !node.is_connected() {
- // TODO: Node should be matched against the style rules of this window.
- // Firefox is currently the only browser to implement this.
return DOMString::new();
}
let addr = node.to_trusted_node_address();