diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-10-16 11:45:28 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-10-16 11:45:28 -0500 |
commit | 4af21e3ae1676f943a9a01688fef854487bcddfc (patch) | |
tree | 484df03ba4719d8e1fbc44efbcc0ab2f9ba8190b | |
parent | ecbdeb330fc96211717c853a312b7558b9d41de3 (diff) | |
parent | d764eef5a2a438387824ef26b90c93193cc5490a (diff) | |
download | servo-4af21e3ae1676f943a9a01688fef854487bcddfc.tar.gz servo-4af21e3ae1676f943a9a01688fef854487bcddfc.zip |
Auto merge of #13787 - lucasloisp:fix-12415/htmll-htmlo, r=emilio
Removed incorrectly exposed webidl interfaces
<!-- Please describe your changes on the following line: -->
I removed exposure in Window and Worker to some interfaces that
was not specified in the specification. Specifically:
- HTMLLinkElement.webidl
- HTMLMapElement.webidl
- HTMLMediaElement.webidl
- HTMLMetaElement.webidl
- HTMLMeterElement.webidl
- HTMLModElement.webidl
- HTMLObjectElement.webidl
- HTMLOListElement.webidl
- HTMLOptGroupElement.webidl
- HTMLOptionElement.webidl
- HTMLOutputElement.webidl
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes partially fix #12415 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they do not add any feature
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13787)
<!-- Reviewable:end -->
12 files changed, 1 insertions, 22 deletions
diff --git a/components/script/dom/webidls/HTMLLinkElement.webidl b/components/script/dom/webidls/HTMLLinkElement.webidl index f792d4ab4c8..8c1bf496590 100644 --- a/components/script/dom/webidls/HTMLLinkElement.webidl +++ b/components/script/dom/webidls/HTMLLinkElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmllinkelement -[Exposed=(Window,Worker)] interface HTMLLinkElement : HTMLElement { attribute DOMString href; // attribute DOMString crossOrigin; diff --git a/components/script/dom/webidls/HTMLMapElement.webidl b/components/script/dom/webidls/HTMLMapElement.webidl index 75fbe322540..5e21b52916e 100644 --- a/components/script/dom/webidls/HTMLMapElement.webidl +++ b/components/script/dom/webidls/HTMLMapElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmlmapelement -[Exposed=(Window,Worker)] interface HTMLMapElement : HTMLElement { // attribute DOMString name; //readonly attribute HTMLCollection areas; diff --git a/components/script/dom/webidls/HTMLMediaElement.webidl b/components/script/dom/webidls/HTMLMediaElement.webidl index 4fa8500d52c..ce952c9b539 100644 --- a/components/script/dom/webidls/HTMLMediaElement.webidl +++ b/components/script/dom/webidls/HTMLMediaElement.webidl @@ -4,7 +4,7 @@ // https://html.spec.whatwg.org/multipage/#htmlmediaelement enum CanPlayTypeResult { "" /* empty string */, "maybe", "probably" }; -[Abstract, Exposed=(Window,Worker)] +[Abstract] interface HTMLMediaElement : HTMLElement { // error state diff --git a/components/script/dom/webidls/HTMLMetaElement.webidl b/components/script/dom/webidls/HTMLMetaElement.webidl index f248c68be5f..20afc297a20 100644 --- a/components/script/dom/webidls/HTMLMetaElement.webidl +++ b/components/script/dom/webidls/HTMLMetaElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmlmetaelement -[Exposed=(Window,Worker)] interface HTMLMetaElement : HTMLElement { attribute DOMString name; // attribute DOMString httpEquiv; diff --git a/components/script/dom/webidls/HTMLMeterElement.webidl b/components/script/dom/webidls/HTMLMeterElement.webidl index 264fd4b0933..c6abe4aef46 100644 --- a/components/script/dom/webidls/HTMLMeterElement.webidl +++ b/components/script/dom/webidls/HTMLMeterElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmlmeterelement -[Exposed=(Window,Worker)] interface HTMLMeterElement : HTMLElement { // attribute double value; // attribute double min; diff --git a/components/script/dom/webidls/HTMLModElement.webidl b/components/script/dom/webidls/HTMLModElement.webidl index 322445dc36d..beda6f97dcc 100644 --- a/components/script/dom/webidls/HTMLModElement.webidl +++ b/components/script/dom/webidls/HTMLModElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmlmodelement -[Exposed=(Window,Worker)] interface HTMLModElement : HTMLElement { // attribute DOMString cite; // attribute DOMString dateTime; diff --git a/components/script/dom/webidls/HTMLOListElement.webidl b/components/script/dom/webidls/HTMLOListElement.webidl index 74c543c62a7..02dc3d1146f 100644 --- a/components/script/dom/webidls/HTMLOListElement.webidl +++ b/components/script/dom/webidls/HTMLOListElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmlolistelement -[Exposed=(Window,Worker)] interface HTMLOListElement : HTMLElement { // attribute boolean reversed; // attribute long start; diff --git a/components/script/dom/webidls/HTMLObjectElement.webidl b/components/script/dom/webidls/HTMLObjectElement.webidl index 20205fd3a6c..ce1d0ff1f8c 100644 --- a/components/script/dom/webidls/HTMLObjectElement.webidl +++ b/components/script/dom/webidls/HTMLObjectElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmlobjectelement -[Exposed=(Window,Worker)] interface HTMLObjectElement : HTMLElement { // attribute DOMString data; attribute DOMString type; diff --git a/components/script/dom/webidls/HTMLOptGroupElement.webidl b/components/script/dom/webidls/HTMLOptGroupElement.webidl index 8ff82d8381b..a81df036a4d 100644 --- a/components/script/dom/webidls/HTMLOptGroupElement.webidl +++ b/components/script/dom/webidls/HTMLOptGroupElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmloptgroupelement -[Exposed=(Window,Worker)] interface HTMLOptGroupElement : HTMLElement { attribute boolean disabled; // attribute DOMString label; diff --git a/components/script/dom/webidls/HTMLOptionElement.webidl b/components/script/dom/webidls/HTMLOptionElement.webidl index d4bc5bcdc83..713ff85a483 100644 --- a/components/script/dom/webidls/HTMLOptionElement.webidl +++ b/components/script/dom/webidls/HTMLOptionElement.webidl @@ -6,7 +6,6 @@ //[NamedConstructor=Option(optional DOMString text = "", optional DOMString value, // optional boolean defaultSelected = false, // optional boolean selected = false)] -[Exposed=(Window,Worker)] interface HTMLOptionElement : HTMLElement { attribute boolean disabled; readonly attribute HTMLFormElement? form; diff --git a/components/script/dom/webidls/HTMLOutputElement.webidl b/components/script/dom/webidls/HTMLOutputElement.webidl index 01003438459..f0baeb8fa03 100644 --- a/components/script/dom/webidls/HTMLOutputElement.webidl +++ b/components/script/dom/webidls/HTMLOutputElement.webidl @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ // https://html.spec.whatwg.org/multipage/#htmloutputelement -[Exposed=(Window,Worker)] interface HTMLOutputElement : HTMLElement { // [SameObject, PutForwards=value] readonly attribute DOMTokenList htmlFor; readonly attribute HTMLFormElement? form; diff --git a/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js b/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js index b5e2a993c87..f940e6d0721 100644 --- a/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js +++ b/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js @@ -47,18 +47,7 @@ test_interfaces([ "HTMLFormControlsCollection", "HTMLFormElement", "HTMLHeadElement", - "HTMLLinkElement", - "HTMLMapElement", - "HTMLMediaElement", - "HTMLMetaElement", - "HTMLMeterElement", - "HTMLModElement", - "HTMLObjectElement", - "HTMLOListElement", - "HTMLOptGroupElement", - "HTMLOptionElement", "HTMLOptionsCollection", - "HTMLOutputElement", "HTMLScriptElement", "ImageData", "KeyboardEvent", |