aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKeith Yeung <kungfukeith11@gmail.com>2018-11-01 12:40:00 -0700
committerKeith Yeung <kungfukeith11@gmail.com>2018-12-11 23:48:46 -0800
commit3ee5a6319951ebc0d4912028a21444254bf6cd80 (patch)
tree6326e096abff561de219f3c0d47476ca6b8e73cf
parent95bfaa0a770479fb3bf6bf0b1f85c9ae343e66ff (diff)
downloadservo-3ee5a6319951ebc0d4912028a21444254bf6cd80.tar.gz
servo-3ee5a6319951ebc0d4912028a21444254bf6cd80.zip
Add onmessageerror to WindowEventHandler
-rw-r--r--components/script/dom/macros.rs2
-rw-r--r--components/script/dom/webidls/EventHandler.webidl1
-rw-r--r--tests/wpt/metadata/html/dom/interfaces.https.html.ini18
-rw-r--r--tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-body-window.html.ini12
-rw-r--r--tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-window-body.html.ini6
-rw-r--r--tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html.ini12
6 files changed, 3 insertions, 48 deletions
diff --git a/components/script/dom/macros.rs b/components/script/dom/macros.rs
index d7281e5bc9c..9b7fffbb508 100644
--- a/components/script/dom/macros.rs
+++ b/components/script/dom/macros.rs
@@ -495,6 +495,7 @@ macro_rules! window_event_handlers(
event_handler!(languagechange, GetOnlanguagechange,
SetOnlanguagechange);
event_handler!(message, GetOnmessage, SetOnmessage);
+ event_handler!(messageerror, GetOnmessageerror, SetOnmessageerror);
event_handler!(offline, GetOnoffline, SetOnoffline);
event_handler!(online, GetOnonline, SetOnonline);
event_handler!(pagehide, GetOnpagehide, SetOnpagehide);
@@ -527,6 +528,7 @@ macro_rules! window_event_handlers(
window_owned_event_handler!(languagechange, GetOnlanguagechange,
SetOnlanguagechange);
window_owned_event_handler!(message, GetOnmessage, SetOnmessage);
+ window_owned_event_handler!(messageerror, GetOnmessageerror, SetOnmessageerror);
window_owned_event_handler!(offline, GetOnoffline, SetOnoffline);
window_owned_event_handler!(online, GetOnonline, SetOnonline);
window_owned_event_handler!(pagehide, GetOnpagehide, SetOnpagehide);
diff --git a/components/script/dom/webidls/EventHandler.webidl b/components/script/dom/webidls/EventHandler.webidl
index 7bd06db5a87..43d57043517 100644
--- a/components/script/dom/webidls/EventHandler.webidl
+++ b/components/script/dom/webidls/EventHandler.webidl
@@ -103,6 +103,7 @@ interface WindowEventHandlers {
attribute EventHandler onhashchange;
attribute EventHandler onlanguagechange;
attribute EventHandler onmessage;
+ attribute EventHandler onmessageerror;
attribute EventHandler onoffline;
attribute EventHandler ononline;
attribute EventHandler onpagehide;
diff --git a/tests/wpt/metadata/html/dom/interfaces.https.html.ini b/tests/wpt/metadata/html/dom/interfaces.https.html.ini
index 749f4ee5890..acc3c9516ff 100644
--- a/tests/wpt/metadata/html/dom/interfaces.https.html.ini
+++ b/tests/wpt/metadata/html/dom/interfaces.https.html.ini
@@ -5995,9 +5995,6 @@
[Window interface: attribute onsecuritypolicyviolation]
expected: FAIL
- [Window interface: attribute onmessageerror]
- expected: FAIL
-
[Window interface: operation createImageBitmap(ImageBitmapSource, ImageBitmapOptions)]
expected: FAIL
@@ -6067,9 +6064,6 @@
[Window interface: window must inherit property "onsecuritypolicyviolation" with the proper type]
expected: FAIL
- [Window interface: window must inherit property "onmessageerror" with the proper type]
- expected: FAIL
-
[Window interface: window must inherit property "createImageBitmap(ImageBitmapSource, ImageBitmapOptions)" with the proper type]
expected: FAIL
@@ -6288,9 +6282,6 @@
[HTMLBodyElement interface: attribute aLink]
expected: FAIL
- [HTMLBodyElement interface: attribute onmessageerror]
- expected: FAIL
-
[HTMLBodyElement interface: document.createElement("body") must inherit property "link" with the proper type]
expected: FAIL
@@ -6300,9 +6291,6 @@
[HTMLBodyElement interface: document.createElement("body") must inherit property "aLink" with the proper type]
expected: FAIL
- [HTMLBodyElement interface: document.createElement("body") must inherit property "onmessageerror" with the proper type]
- expected: FAIL
-
[HTMLHeadingElement interface: attribute align]
expected: FAIL
@@ -9555,18 +9543,12 @@
[HTMLFrameSetElement interface: attribute rows]
expected: FAIL
- [HTMLFrameSetElement interface: attribute onmessageerror]
- expected: FAIL
-
[HTMLFrameSetElement interface: document.createElement("frameset") must inherit property "cols" with the proper type]
expected: FAIL
[HTMLFrameSetElement interface: document.createElement("frameset") must inherit property "rows" with the proper type]
expected: FAIL
- [HTMLFrameSetElement interface: document.createElement("frameset") must inherit property "onmessageerror" with the proper type]
- expected: FAIL
-
[HTMLFrameElement interface: attribute name]
expected: FAIL
diff --git a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-body-window.html.ini b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-body-window.html.ini
index 9cf46d44644..e564ff94d4d 100644
--- a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-body-window.html.ini
+++ b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-body-window.html.ini
@@ -9,9 +9,6 @@
[shadowed error (document.body)]
expected: FAIL
- [shadowed messageerror (document.body)]
- expected: FAIL
-
[not shadowed auxclick (document.body)]
expected: FAIL
@@ -30,15 +27,9 @@
[not shadowed paste (document.body)]
expected: FAIL
- [shadowed messageerror removal (document.body)]
- expected: FAIL
-
[shadowed error (document.createElement("body"))]
expected: FAIL
- [shadowed messageerror (document.createElement("body"))]
- expected: FAIL
-
[not shadowed auxclick (document.createElement("body"))]
expected: FAIL
@@ -57,6 +48,3 @@
[not shadowed paste (document.createElement("body"))]
expected: FAIL
- [shadowed messageerror removal (document.createElement("body"))]
- expected: FAIL
-
diff --git a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-window-body.html.ini b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-window-body.html.ini
index c87a63d1723..82c32c1c529 100644
--- a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-window-body.html.ini
+++ b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-window-body.html.ini
@@ -8,9 +8,6 @@
[shadowed error]
expected: FAIL
- [shadowed messageerror]
- expected: FAIL
-
[not shadowed auxclick]
expected: FAIL
@@ -20,6 +17,3 @@
[not shadowed securitypolicyviolation]
expected: FAIL
- [shadowed messageerror removal]
- expected: FAIL
-
diff --git a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html.ini b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html.ini
index 9082fbf883d..3789d6f2139 100644
--- a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html.ini
+++ b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html.ini
@@ -5,12 +5,6 @@
[Ignore setting of error window event handlers on windowless body]
expected: FAIL
- [Return null when getting the messageerror event handler of a windowless body]
- expected: FAIL
-
- [Ignore setting of messageerror window event handlers on windowless body]
- expected: FAIL
-
[auxclick is unaffected on a windowless body]
expected: FAIL
@@ -23,12 +17,6 @@
[Ignore setting of error window event handlers on windowless frameset]
expected: FAIL
- [Return null when getting the messageerror event handler of a windowless frameset]
- expected: FAIL
-
- [Ignore setting of messageerror window event handlers on windowless frameset]
- expected: FAIL
-
[auxclick is unaffected on a windowless frameset]
expected: FAIL