aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHiroyuki Ikezoe <hikezoe@mozilla.com>2017-08-08 10:01:46 +0900
committerHiroyuki Ikezoe <hikezoe@mozilla.com>2017-08-08 10:01:47 +0900
commitbdf84510f8f61c328f774351072bb4d37b9d6daa (patch)
tree28a28f858f91c97c04bbfb8b81766533dff7d1a3
parentc9d9ed8e96b88bf738c8753106424bbb28a4b02e (diff)
downloadservo-bdf84510f8f61c328f774351072bb4d37b9d6daa.tar.gz
servo-bdf84510f8f61c328f774351072bb4d37b9d6daa.zip
Don't clear animation only dirty bit during style recalc (unless the element is in a display:none subtree).
After bug 1356141, the setup of animation-only dirty bit should have matched to normal dirty bit's one (Though they don't match in post traversal due to throttled animation flush). An unset_animation_only_dirty_descendants call removed in this patch cleared dirty bits which are needed for post traversal if there is a second animation-only traversal and if there is no need to restyle for the second animation-only traversal. The reftest in this patch fails without either this fix or the fix for bug 1367975. See [Gecko bug 1384435 comment 12](https://bugzilla.mozilla.org/show_bug.cgi?id=1384435#c12) for more detail what's going on at that time.
-rw-r--r--components/style/traversal.rs3
1 files changed, 0 insertions, 3 deletions
diff --git a/components/style/traversal.rs b/components/style/traversal.rs
index cd90f568753..a430ad22ad7 100644
--- a/components/style/traversal.rs
+++ b/components/style/traversal.rs
@@ -563,9 +563,6 @@ where
} else {
element.has_dirty_descendants()
};
- if flags.for_animation_only() {
- unsafe { element.unset_animation_only_dirty_descendants(); }
- }
// Before examining each child individually, try to prove that our children
// don't need style processing. They need processing if any of the following