aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <servo-ops@mozilla.com>2020-06-20 10:20:25 -0400
committerGitHub <noreply@github.com>2020-06-20 10:20:25 -0400
commita6de9e01ab7a063859465c295a86de0845b1a053 (patch)
treefc65e80e1c3b0ff869f5775b8b7ece5b226c0bd8
parent0b61cfc3ae803ac0f9deef937f890f83b24c9a35 (diff)
parentbb1d3193e509c96f78246dec4740fd3df37eb72c (diff)
downloadservo-a6de9e01ab7a063859465c295a86de0845b1a053.tar.gz
servo-a6de9e01ab7a063859465c295a86de0845b1a053.zip
Auto merge of #27001 - saschanaz:no-mp-hack, r=jdm
Don't run multiprocessing hack on Python 3 <!-- Please describe your changes on the following line: --> This ports https://phabricator.services.mozilla.com/D42016. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
-rwxr-xr-xmach8
1 files changed, 7 insertions, 1 deletions
diff --git a/mach b/mach
index 317374d6c27..9758e1e2cef 100755
--- a/mach
+++ b/mach
@@ -36,7 +36,7 @@ def main(args):
if __name__ == '__main__':
sys.dont_write_bytecode = True
- if sys.platform == 'win32':
+ if sys.platform == 'win32' and sys.version_info < (3, 4):
# This is a complete hack to work around the fact that Windows
# multiprocessing needs to import the original module (ie: this
# file), but only works if it has a .py extension.
@@ -54,6 +54,12 @@ if __name__ == '__main__':
#
# See also: http://bugs.python.org/issue19946
# And: https://bugzilla.mozilla.org/show_bug.cgi?id=914563
+ # XXX In Python 3.4 the multiprocessing module was re-written and the
+ # below code is no longer valid. The Python issue19946 also claims to
+ # be fixed in this version. It's not clear whether this hack is still
+ # needed in 3.4+ or not, but at least some basic mach commands appear
+ # to work without it. So skip it in 3.4+ until we determine it's still
+ # needed.
import inspect
from multiprocessing import forking
global orig_command_line