aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2020-01-02 23:56:36 -0500
committerGitHub <noreply@github.com>2020-01-02 23:56:36 -0500
commit3892d85fe09b39f8ff56e53a4875488fb2951dd5 (patch)
tree8e94fb007817725a03eac3c1dce6f53ccd877a88
parentd47f0ad1f672c7f1543eb753fc87c6acdf9f16e8 (diff)
parentb20881639e1e0b55500b90babc1ac7a8bdf1f32d (diff)
downloadservo-3892d85fe09b39f8ff56e53a4875488fb2951dd5.tar.gz
servo-3892d85fe09b39f8ff56e53a4875488fb2951dd5.zip
Auto merge of #25407 - pshaughn:radiocase, r=jdm
Radio button grouping is now case-sensitive Just catching up with a spec update, as explained in #25389 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25389 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
-rwxr-xr-xcomponents/script/dom/htmlinputelement.rs3
-rw-r--r--tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini26
2 files changed, 1 insertions, 28 deletions
diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs
index 9018f05813a..0cef0a10535 100755
--- a/components/script/dom/htmlinputelement.rs
+++ b/components/script/dom/htmlinputelement.rs
@@ -46,7 +46,6 @@ use crate::textinput::KeyReaction::{
};
use crate::textinput::Lines::Single;
use crate::textinput::{Direction, SelectionDirection, TextInput, UTF16CodeUnits, UTF8Bytes};
-use caseless::compatibility_caseless_match_str;
use dom_struct::dom_struct;
use embedder_traits::FilterPattern;
use encoding_rs::Encoding;
@@ -917,7 +916,7 @@ fn in_same_group(
// TODO Both a and b are in the same home subtree.
other.form_owner().as_deref() == owner &&
match (other.radio_group_name(), group) {
- (Some(ref s1), Some(s2)) => compatibility_caseless_match_str(s1, s2) && s2 != &atom!(""),
+ (Some(ref s1), Some(s2)) => s1 == s2 && s2 != &atom!(""),
_ => false
}
}
diff --git a/tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini b/tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini
deleted file mode 100644
index 69e88a9bd4e..00000000000
--- a/tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini
+++ /dev/null
@@ -1,26 +0,0 @@
-[radio-groupname-case.html]
- type: testharness
- [radio button group name = paSSfield-killroyß]
- expected: FAIL
-
- [Among names like sImPlE, everything must be checkable at the same time]
- expected: FAIL
-
- [Among names like paSSfield-killroyß, everything must be checkable at the same time]
- expected: FAIL
-
- [Among names like глупый, everything must be checkable at the same time]
- expected: FAIL
-
- [Among names like åωk, everything must be checkable at the same time]
- expected: FAIL
-
- [Among names like blah1, everything must be checkable at the same time]
- expected: FAIL
-
- [Among names like tÉdz5アパートFi, everything must be checkable at the same time]
- expected: FAIL
-
- [Among names like ΣΣ, everything must be checkable at the same time]
- expected: FAIL
-