diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-04-07 10:56:35 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-07 10:56:35 -0400 |
| commit | 1a21c047ffa0ebf5ffc23f02f26e5ac6e8bbf2f0 (patch) | |
| tree | 72698205fc6c03a861e075aca9e96de7bfab6adc | |
| parent | 65e37e68452befc98eaafb8e24cb3b00e8b43269 (diff) | |
| parent | aa0b4abc9d663a237c7783c2dd8c736a6c2f7343 (diff) | |
| download | servo-1a21c047ffa0ebf5ffc23f02f26e5ac6e8bbf2f0.tar.gz servo-1a21c047ffa0ebf5ffc23f02f26e5ac6e8bbf2f0.zip | |
Auto merge of #23175 - servo:CYBAI-patch-1, r=jdm
Add a note to indicate PKG_CONFIG_PATH required
I just got the error messages like #23015 again and then I think the root cause should be about
`PKG_CONFIG_PATH`. After following https://github.com/servo/servo/issues/23015#issuecomment-475050175 said, I can build Servo successfully.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because this just updates README.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23175)
<!-- Reviewable:end -->
| -rw-r--r-- | README.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/README.md b/README.md index 5f07a08df0a..a38d6250aaa 100644 --- a/README.md +++ b/README.md @@ -76,6 +76,8 @@ export OPENSSL_LIB_DIR="$(brew --prefix openssl)/lib" ./mach build ... ``` +##### Note: Please make sure the required `PKG_CONFIG_PATH` environment variable is set the same as the one provided from `brew info libffi` ([Check this comment for more details](https://github.com/servo/servo/issues/23015#issuecomment-475050175)). + If you've already partially compiled servo but forgot to do this step, run `./mach clean`, set the shell variables, and recompile. #### On Debian-based Linuxes |