aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Gaynor <alex.gaynor@gmail.com>2015-11-19 19:53:36 -0500
committerAlex Gaynor <alex.gaynor@gmail.com>2015-11-20 11:40:07 -0500
commit008d99663fca14d88aeec2509c867227f8135974 (patch)
treeec0bd8571f0999287315fcdfb3efcb826b86ff9c
parent8b39b9afed6ef8a3d7d3e6609fd301a37825d3e1 (diff)
downloadservo-008d99663fca14d88aeec2509c867227f8135974.tar.gz
servo-008d99663fca14d88aeec2509c867227f8135974.zip
Fixed #8594 -- use a more modern default cipher suite list by default
-rw-r--r--components/net/http_loader.rs17
1 files changed, 17 insertions, 0 deletions
diff --git a/components/net/http_loader.rs b/components/net/http_loader.rs
index 8ffcd787e9d..e8810335acf 100644
--- a/components/net/http_loader.rs
+++ b/components/net/http_loader.rs
@@ -44,10 +44,27 @@ use uuid;
pub type Connector = HttpsConnector<Openssl>;
+// The basic logic here is to prefer ciphers with ECDSA certificates, Forward
+// Secrecy, AES GCM ciphers, AES ciphers, and finally 3DES ciphers.
+// A complete discussion of the issues involved in TLS configuration can be found here:
+// https://wiki.mozilla.org/Security/Server_Side_TLS
+const DEFAULT_CIPHERS: &'static str = concat!(
+ "ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:",
+ "ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:",
+ "DHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-SHA256:",
+ "ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:",
+ "ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES256-SHA:",
+ "ECDHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:",
+ "DHE-RSA-AES256-SHA256:DHE-RSA-AES256-SHA:ECDHE-RSA-DES-CBC3-SHA:",
+ "ECDHE-ECDSA-DES-CBC3-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:",
+ "AES128-SHA256:AES256-SHA256:AES128-SHA:AES256-SHA"
+);
+
pub fn create_http_connector() -> Arc<Pool<Connector>> {
let mut context = SslContext::new(SslMethod::Sslv23).unwrap();
context.set_verify(SSL_VERIFY_PEER, None);
context.set_CA_file(&resources_dir_path().join("certs")).unwrap();
+ context.set_cipher_list(DEFAULT_CIPHERS).unwrap();
let connector = HttpsConnector::new(Openssl {
context: Arc::new(context)
});