diff options
| author | shanehandley <1322294+shanehandley@users.noreply.github.com> | 2024-07-29 01:01:01 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-28 15:01:01 +0000 |
| commit | ed8def28960fd64fa0d00bd67731d594c1042747 (patch) | |
| tree | a05b4d5b3aabb814681aa5e1303dcdac744fe941 | |
| parent | bc75bf4cfa42d627309bd003dbb6dab3f3233dfd (diff) | |
| download | servo-ed8def28960fd64fa0d00bd67731d594c1042747.tar.gz servo-ed8def28960fd64fa0d00bd67731d594c1042747.zip | |
Add the type IDL attribute to htmlfieldsetelement (#32869)
* Add the type IDL attribute to htmlfieldsetelement
Signed-off-by: Shane Handley <shanehandley@fastmail.com>
* Fix missing idlharness test expectations
Signed-off-by: Shane Handley <shanehandley@fastmail.com>
---------
Signed-off-by: Shane Handley <shanehandley@fastmail.com>
6 files changed, 6 insertions, 14 deletions
diff --git a/components/script/dom/htmlfieldsetelement.rs b/components/script/dom/htmlfieldsetelement.rs index bdc5c72507b..e3ee73c125a 100644 --- a/components/script/dom/htmlfieldsetelement.rs +++ b/components/script/dom/htmlfieldsetelement.rs @@ -144,6 +144,11 @@ impl HTMLFieldSetElementMethods for HTMLFieldSetElement { fn SetCustomValidity(&self, error: DOMString) { self.validity_state().set_custom_error_message(error); } + + /// <https://html.spec.whatwg.org/multipage/#dom-fieldset-type> + fn Type(&self) -> DOMString { + DOMString::from_string(String::from("fieldset")) + } } impl VirtualMethods for HTMLFieldSetElement { diff --git a/components/script/dom/webidls/HTMLFieldSetElement.webidl b/components/script/dom/webidls/HTMLFieldSetElement.webidl index 8774d75a537..494dae3a5a2 100644 --- a/components/script/dom/webidls/HTMLFieldSetElement.webidl +++ b/components/script/dom/webidls/HTMLFieldSetElement.webidl @@ -13,7 +13,7 @@ interface HTMLFieldSetElement : HTMLElement { [CEReactions] attribute DOMString name; - //readonly attribute DOMString type; + readonly attribute DOMString type; [SameObject] readonly attribute HTMLCollection elements; diff --git a/tests/wpt/meta-legacy-layout/html/dom/idlharness.https.html.ini b/tests/wpt/meta-legacy-layout/html/dom/idlharness.https.html.ini index cdbd11bee52..7a4c11216d0 100644 --- a/tests/wpt/meta-legacy-layout/html/dom/idlharness.https.html.ini +++ b/tests/wpt/meta-legacy-layout/html/dom/idlharness.https.html.ini @@ -2979,9 +2979,6 @@ [HTMLEmbedElement interface: document.createElement("embed") must inherit property "name" with the proper type] expected: FAIL - [HTMLFieldSetElement interface: attribute type] - expected: FAIL - [HTMLInputElement interface: createInput("tel") must inherit property "useMap" with the proper type] expected: FAIL diff --git a/tests/wpt/meta-legacy-layout/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini b/tests/wpt/meta-legacy-layout/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini index 9bdcfee9aeb..724bb746d34 100644 --- a/tests/wpt/meta-legacy-layout/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini +++ b/tests/wpt/meta-legacy-layout/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini @@ -1,8 +1,4 @@ [HTMLFieldSetElement.html] type: testharness - [The type attribute must return 'fieldset'] - expected: FAIL - [The elements must return an HTMLFormControlsCollection object] expected: FAIL - diff --git a/tests/wpt/meta/html/dom/idlharness.https.html.ini b/tests/wpt/meta/html/dom/idlharness.https.html.ini index 3555bfd253d..16ad66da7c7 100644 --- a/tests/wpt/meta/html/dom/idlharness.https.html.ini +++ b/tests/wpt/meta/html/dom/idlharness.https.html.ini @@ -2823,9 +2823,6 @@ [HTMLEmbedElement interface: document.createElement("embed") must inherit property "name" with the proper type] expected: FAIL - [HTMLFieldSetElement interface: attribute type] - expected: FAIL - [HTMLInputElement interface: createInput("tel") must inherit property "useMap" with the proper type] expected: FAIL diff --git a/tests/wpt/meta/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini b/tests/wpt/meta/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini deleted file mode 100644 index f9e43be272d..00000000000 --- a/tests/wpt/meta/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini +++ /dev/null @@ -1,3 +0,0 @@ -[HTMLFieldSetElement.html] - [The type attribute must return 'fieldset'] - expected: FAIL |