diff options
| author | Ms2ger <Ms2ger@gmail.com> | 2016-03-16 14:47:26 +0100 |
|---|---|---|
| committer | Ms2ger <Ms2ger@gmail.com> | 2016-03-16 14:47:26 +0100 |
| commit | c15fa8bf25728ccc295b288770331ae97695fec2 (patch) | |
| tree | 2cfb717bebd20a0de2cb1817e1854b8dcf5098f8 | |
| parent | ad47c093ad897ef6e9ab93df5ea90c5a6e2ef3b3 (diff) | |
| download | servo-c15fa8bf25728ccc295b288770331ae97695fec2.tar.gz servo-c15fa8bf25728ccc295b288770331ae97695fec2.zip | |
Use call rather than check_call in jquery_test_runner.
The contract for mach commands is to return zero / non-zero to indicate
success / failure, rather than throwing an exception. Since run_jquery.py
uses a 1 exit code when there are unexpected results, this would cause an
exception from check_call, which would then be printed with a stack trace.
| -rw-r--r-- | python/servo/testing_commands.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index ddd8cc90918..7d76ad80e65 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -497,8 +497,7 @@ class MachCommands(CommandBase): # Check that a release servo build exists bin_path = path.abspath(self.get_binary_path(release, dev)) - return check_call( - [run_file, cmd, bin_path, base_dir]) + return call([run_file, cmd, bin_path, base_dir]) def dromaeo_test_runner(self, tests, release, dev): self.ensure_bootstrapped() |