aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Robinson <mrobinson@igalia.com>2025-01-30 10:21:23 +0100
committerGitHub <noreply@github.com>2025-01-30 09:21:23 +0000
commit9eeb602f7afca502753bb8211ab646c952951761 (patch)
tree63be21e998f4464dba3637d314709d3f45bbefd7
parent8813f52b207a4023966774c16b25e8a170b16edb (diff)
downloadservo-9eeb602f7afca502753bb8211ab646c952951761.tar.gz
servo-9eeb602f7afca502753bb8211ab646c952951761.zip
compositor: Remove some unused messages to the compositor (#35223)
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
-rw-r--r--components/compositing/compositor.rs29
-rw-r--r--components/compositing/tracing.rs4
-rw-r--r--components/shared/compositing/lib.rs13
3 files changed, 0 insertions, 46 deletions
diff --git a/components/compositing/compositor.rs b/components/compositing/compositor.rs
index 5bb5eeef9f3..6a6626040b9 100644
--- a/components/compositing/compositor.rs
+++ b/components/compositing/compositor.rs
@@ -517,35 +517,6 @@ impl IOCompositor {
self.remove_webview(top_level_browsing_context_id);
},
- // TODO: remove this
- CompositorMsg::MoveResizeWebView(webview_id, rect) => {
- self.move_resize_webview(webview_id, rect);
- },
-
- // TODO: remove this
- CompositorMsg::ShowWebView(webview_id, hide_others) => {
- if let Err(UnknownWebView(webview_id)) = self.show_webview(webview_id, hide_others)
- {
- warn!("{webview_id}: ShowWebView on unknown webview id");
- }
- },
-
- // TODO: remove this
- CompositorMsg::HideWebView(webview_id) => {
- if let Err(UnknownWebView(webview_id)) = self.hide_webview(webview_id) {
- warn!("{webview_id}: HideWebView on unknown webview id");
- }
- },
-
- // TODO: remove this
- CompositorMsg::RaiseWebViewToTop(webview_id, hide_others) => {
- if let Err(UnknownWebView(webview_id)) =
- self.raise_webview_to_top(webview_id, hide_others)
- {
- warn!("{webview_id}: RaiseWebViewToTop on unknown webview id");
- }
- },
-
CompositorMsg::TouchEventProcessed(result) => {
self.touch_handler.on_event_processed(result);
},
diff --git a/components/compositing/tracing.rs b/components/compositing/tracing.rs
index 0b4e4ceaa35..7b0c696a62b 100644
--- a/components/compositing/tracing.rs
+++ b/components/compositing/tracing.rs
@@ -34,10 +34,6 @@ mod from_constellation {
Self::ChangeRunningAnimationsState(..) => target!("ChangeRunningAnimationsState"),
Self::CreateOrUpdateWebView(..) => target!("CreateOrUpdateWebView"),
Self::RemoveWebView(..) => target!("RemoveWebView"),
- Self::MoveResizeWebView(..) => target!("MoveResizeWebView"),
- Self::ShowWebView(..) => target!("ShowWebView"),
- Self::HideWebView(..) => target!("HideWebView"),
- Self::RaiseWebViewToTop(..) => target!("RaiseWebViewToTop"),
Self::TouchEventProcessed(..) => target!("TouchEventProcessed"),
Self::CreatePng(..) => target!("CreatePng"),
Self::IsReadyToSaveImageReply(..) => target!("IsReadyToSaveImageReply"),
diff --git a/components/shared/compositing/lib.rs b/components/shared/compositing/lib.rs
index bf8a3cf02a9..6c8dcd695f6 100644
--- a/components/shared/compositing/lib.rs
+++ b/components/shared/compositing/lib.rs
@@ -19,7 +19,6 @@ use log::warn;
use pixels::Image;
use script_traits::{AnimationState, ConstellationControlMsg, EventResult};
use style_traits::CSSPixel;
-use webrender_api::units::DeviceRect;
use webrender_api::DocumentId;
use webrender_traits::{CrossProcessCompositorApi, CrossProcessCompositorMessage};
@@ -69,14 +68,6 @@ pub enum CompositorMsg {
CreateOrUpdateWebView(SendableFrameTree),
/// Remove a webview.
RemoveWebView(TopLevelBrowsingContextId),
- /// Move and/or resize a webview to the given rect.
- MoveResizeWebView(TopLevelBrowsingContextId, DeviceRect),
- /// Start painting a webview, and optionally stop painting all others.
- ShowWebView(TopLevelBrowsingContextId, bool),
- /// Stop painting a webview.
- HideWebView(TopLevelBrowsingContextId),
- /// Start painting a webview on top of all others, and optionally stop painting all others.
- RaiseWebViewToTop(TopLevelBrowsingContextId, bool),
/// Script has handled a touch event, and either prevented or allowed default actions.
TouchEventProcessed(EventResult),
/// Composite to a PNG file and return the Image over a passed channel.
@@ -133,10 +124,6 @@ impl Debug for CompositorMsg {
},
CompositorMsg::CreateOrUpdateWebView(..) => write!(f, "CreateOrUpdateWebView"),
CompositorMsg::RemoveWebView(..) => write!(f, "RemoveWebView"),
- CompositorMsg::MoveResizeWebView(..) => write!(f, "MoveResizeWebView"),
- CompositorMsg::ShowWebView(..) => write!(f, "ShowWebView"),
- CompositorMsg::HideWebView(..) => write!(f, "HideWebView"),
- CompositorMsg::RaiseWebViewToTop(..) => write!(f, "RaiseWebViewToTop"),
CompositorMsg::TouchEventProcessed(..) => write!(f, "TouchEventProcessed"),
CompositorMsg::CreatePng(..) => write!(f, "CreatePng"),
CompositorMsg::IsReadyToSaveImageReply(..) => write!(f, "IsReadyToSaveImageReply"),