aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2016-12-14 07:31:41 -0800
committerGitHub <noreply@github.com>2016-12-14 07:31:41 -0800
commit385d9bc1fa41e11560e2a7c26e9916350b0a66e2 (patch)
tree5bbc11d03b839e9ba148b5ff93e7a50b47465ace
parent65b891c23fbb85c32ae07e2c5495b82b29b3331a (diff)
parent6bea1b53e6a3d51bdc8de269260df540fb674116 (diff)
downloadservo-385d9bc1fa41e11560e2a7c26e9916350b0a66e2.tar.gz
servo-385d9bc1fa41e11560e2a7c26e9916350b0a66e2.zip
Auto merge of #14570 - servo:resource-thread, r=emilio
Remove some dead code related to the old network stack. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570) <!-- Reviewable:end -->
-rw-r--r--components/net/resource_thread.rs93
-rw-r--r--components/net_traits/lib.rs28
2 files changed, 4 insertions, 117 deletions
diff --git a/components/net/resource_thread.rs b/components/net/resource_thread.rs
index 0a4cc89d806..aef1ee314d2 100644
--- a/components/net/resource_thread.rs
+++ b/components/net/resource_thread.rs
@@ -14,17 +14,13 @@ use filemanager_thread::{FileManager, TFDProvider};
use hsts::HstsList;
use http_loader::HttpState;
use hyper::client::pool::Pool;
-use hyper::header::{ContentType, Header, SetCookie};
-use hyper::mime::{Mime, SubLevel, TopLevel};
+use hyper::header::{Header, SetCookie};
use hyper_serde::Serde;
use ipc_channel::ipc::{self, IpcReceiver, IpcReceiverSet, IpcSender};
-use mime_classifier::{ApacheBugFlag, MimeClassifier, NoSniffFlag};
-use net_traits::{CookieSource, CoreResourceThread, Metadata, ProgressMsg};
-use net_traits::{CoreResourceMsg, FetchResponseMsg, FetchTaskTarget, LoadConsumer};
-use net_traits::{CustomResponseMediator, LoadResponse, NetworkError, ResourceId};
+use net_traits::{CookieSource, CoreResourceThread};
+use net_traits::{CoreResourceMsg, FetchResponseMsg, FetchTaskTarget};
+use net_traits::{CustomResponseMediator, ResourceId};
use net_traits::{ResourceThreads, WebSocketCommunicate, WebSocketConnectData};
-use net_traits::LoadContext;
-use net_traits::ProgressMsg::Done;
use net_traits::request::{Request, RequestInit};
use net_traits::storage_thread::StorageThreadMsg;
use profile_traits::time::ProfilerChan;
@@ -42,16 +38,11 @@ use std::rc::Rc;
use std::sync::{Arc, RwLock};
use std::sync::mpsc::Sender;
use storage_thread::StorageThreadFactory;
-use util::prefs::PREFS;
use util::thread::spawn_named;
use websocket_loader;
const TFD_PROVIDER: &'static TFDProvider = &TFDProvider;
-pub enum ProgressSender {
- Channel(IpcSender<ProgressMsg>),
-}
-
#[derive(Clone)]
pub struct ResourceGroup {
cookie_jar: Arc<RwLock<CookieStorage>>,
@@ -60,82 +51,6 @@ pub struct ResourceGroup {
connector: Arc<Pool<Connector>>,
}
-impl ProgressSender {
- //XXXjdm return actual error
- pub fn send(&self, msg: ProgressMsg) -> Result<(), ()> {
- match *self {
- ProgressSender::Channel(ref c) => c.send(msg).map_err(|_| ()),
- }
- }
-}
-
-pub fn send_error(url: ServoUrl, err: NetworkError, start_chan: LoadConsumer) {
- let mut metadata: Metadata = Metadata::default(url);
- metadata.status = None;
-
- if let Ok(p) = start_sending_opt(start_chan, metadata) {
- p.send(Done(Err(err))).unwrap();
- }
-}
-
-/// For use by loaders in responding to a Load message that allows content sniffing.
-pub fn start_sending_sniffed_opt(start_chan: LoadConsumer, mut metadata: Metadata,
- classifier: Arc<MimeClassifier>, partial_body: &[u8],
- context: LoadContext)
- -> Result<ProgressSender, ()> {
- if PREFS.get("network.mime.sniff").as_boolean().unwrap_or(false) {
- // TODO: should be calculated in the resource loader, from pull requeset #4094
- let mut no_sniff = NoSniffFlag::Off;
- let mut check_for_apache_bug = ApacheBugFlag::Off;
-
- if let Some(ref headers) = metadata.headers {
- if let Some(ref content_type) = headers.get_raw("content-type").and_then(|c| c.last()) {
- check_for_apache_bug = ApacheBugFlag::from_content_type(content_type)
- }
- if let Some(ref raw_content_type_options) = headers.get_raw("X-content-type-options") {
- if raw_content_type_options.iter().any(|ref opt| *opt == b"nosniff") {
- no_sniff = NoSniffFlag::On
- }
- }
- }
-
- let supplied_type =
- metadata.content_type.as_ref().map(|&Serde(ContentType(Mime(ref toplevel, ref sublevel, _)))| {
- (toplevel.to_owned(), format!("{}", sublevel))
- });
- let (toplevel, sublevel) = classifier.classify(context,
- no_sniff,
- check_for_apache_bug,
- &supplied_type,
- &partial_body);
- let mime_tp: TopLevel = toplevel.into();
- let mime_sb: SubLevel = sublevel.parse().unwrap();
- metadata.content_type =
- Some(Serde(ContentType(Mime(mime_tp, mime_sb, vec![]))));
- }
-
- start_sending_opt(start_chan, metadata)
-}
-
-/// For use by loaders in responding to a Load message.
-/// It takes an optional NetworkError, so that we can extract the SSL Validation errors
-/// and take it to the HTML parser
-fn start_sending_opt(start_chan: LoadConsumer, metadata: Metadata) -> Result<ProgressSender, ()> {
- match start_chan {
- LoadConsumer::Channel(start_chan) => {
- let (progress_chan, progress_port) = ipc::channel().unwrap();
- let result = start_chan.send(LoadResponse {
- metadata: metadata,
- progress_port: progress_port,
- });
- match result {
- Ok(_) => Ok(ProgressSender::Channel(progress_chan)),
- Err(_) => Err(())
- }
- }
- }
-}
-
/// Returns a tuple of (public, private) senders to the new threads.
pub fn new_resource_threads(user_agent: Cow<'static, str>,
devtools_chan: Option<Sender<DevtoolsControlMsg>>,
diff --git a/components/net_traits/lib.rs b/components/net_traits/lib.rs
index bd0fae8d777..b17a33fd421 100644
--- a/components/net_traits/lib.rs
+++ b/components/net_traits/lib.rs
@@ -245,12 +245,6 @@ impl<T: BluetoothResponseListener> Action<T> for BluetoothResponseResult {
}
}
-/// A wrapper for a network load that can either be channel or event-based.
-#[derive(Deserialize, Serialize)]
-pub enum LoadConsumer {
- Channel(IpcSender<LoadResponse>),
-}
-
/// Handle to a resource thread
pub type CoreResourceThread = IpcSender<CoreResourceMsg>;
@@ -401,19 +395,6 @@ pub fn fetch_async<F>(request: RequestInit,
core_resource_thread.send(CoreResourceMsg::Fetch(request, action_sender)).unwrap();
}
-/// Message sent in response to `Load`. Contains metadata, and a port
-/// for receiving the data.
-///
-/// Even if loading fails immediately, we send one of these and the
-/// progress_port will provide the error.
-#[derive(Serialize, Deserialize)]
-pub struct LoadResponse {
- /// Metadata, such as from HTTP headers.
- pub metadata: Metadata,
- /// Port for reading data.
- pub progress_port: IpcReceiver<ProgressMsg>,
-}
-
#[derive(Clone, Deserialize, Serialize, HeapSizeOf)]
pub struct ResourceCorsData {
/// CORS Preflight flag
@@ -499,15 +480,6 @@ pub enum CookieSource {
NonHTTP,
}
-/// Messages sent in response to a `Load` message
-#[derive(PartialEq, Debug, Deserialize, Serialize)]
-pub enum ProgressMsg {
- /// Binary data - there may be multiple of these
- Payload(Vec<u8>),
- /// Indicates loading is complete, either successfully or not
- Done(Result<(), NetworkError>),
-}
-
/// Convenience function for synchronously loading a whole resource.
pub fn load_whole_resource(request: RequestInit,
core_resource_thread: &CoreResourceThread)