diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-06-08 19:01:42 -0500 |
---|---|---|
committer | bors-servo <lbergstrom+bors@mozilla.com> | 2016-06-08 19:01:42 -0500 |
commit | 28c0b869cab72020edbc54e5ccd761dc2dbb92b2 (patch) | |
tree | 313cba1013539fe4992bd2dfe0d3108fe43c67d4 | |
parent | e51ce5d1bac31afdadc9a4c86175fac00677b31a (diff) | |
parent | 64c5c3ee9d0523b65d21d863a6920161ec2d16fd (diff) | |
download | servo-28c0b869cab72020edbc54e5ccd761dc2dbb92b2.tar.gz servo-28c0b869cab72020edbc54e5ccd761dc2dbb92b2.zip |
Auto merge of #11543 - UK992:browserhtml, r=metajack
Fix ./mach --browserhtml
Rebased https://github.com/servo/servo/pull/10943 and simplified by https://github.com/servo/servo/pull/10943#issuecomment-221643014.
Fixes path related issue with browser.html on Windows and enable borderless window only on OSX.
r? @metajack
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11543)
<!-- Reviewable:end -->
-rw-r--r-- | python/servo/command_base.py | 9 | ||||
-rw-r--r-- | python/servo/post_build_commands.py | 12 |
2 files changed, 19 insertions, 2 deletions
diff --git a/python/servo/command_base.py b/python/servo/command_base.py index 4618882627c..66c4a0caa17 100644 --- a/python/servo/command_base.py +++ b/python/servo/command_base.py @@ -105,6 +105,15 @@ def check_call(*args, **kwargs): return subprocess.check_call(*args, shell=sys.platform == 'win32', **kwargs) +def is_windows(): + """ Detect windows, mingw, cygwin """ + return sys.platform == 'win32' or sys.platform == 'msys' or sys.platform == 'cygwin' + + +def is_macosx(): + return sys.platform == 'darwin' + + class BuildNotFound(Exception): def __init__(self, message): self.message = message diff --git a/python/servo/post_build_commands.py b/python/servo/post_build_commands.py index 7781689d32b..33bbca0f19b 100644 --- a/python/servo/post_build_commands.py +++ b/python/servo/post_build_commands.py @@ -23,7 +23,7 @@ from mach.decorators import ( Command, ) -from servo.command_base import CommandBase, cd, call, check_call +from servo.command_base import CommandBase, cd, call, check_call, is_windows, is_macosx def read_file(filename, if_exists=False): @@ -131,7 +131,15 @@ class PostBuildCommands(CommandBase): if browserhtml_path is None: print("Could not find browserhtml package; perhaps you haven't built Servo.") return 1 - args = args + ['-w', '-b', + + if is_macosx(): + # Enable borderless on OSX + args = args + ['-b'] + elif is_windows(): + # Convert to a relative path to avoid mingw -> Windows path conversions + browserhtml_path = path.relpath(browserhtml_path, os.getcwd()) + + args = args + ['-w', '--pref', 'dom.mozbrowser.enabled', '--pref', 'dom.forcetouch.enabled', '--pref', 'shell.quit-on-escape.enabled=false', |