diff options
| author | bors-servo <metajack+bors@gmail.com> | 2015-03-13 10:42:49 -0600 |
|---|---|---|
| committer | bors-servo <metajack+bors@gmail.com> | 2015-03-13 10:42:49 -0600 |
| commit | 2382d71242b1f9fe6385b64436f3b18f8f0939bb (patch) | |
| tree | 0a690b74852cf52ff6451adad0be38761eb5b11a | |
| parent | a50807051b0ff9a46ce6f76189617534b8294276 (diff) | |
| parent | d80abce13efbe5e1d86d31bcc8d61aa11b233b98 (diff) | |
| download | servo-2382d71242b1f9fe6385b64436f3b18f8f0939bb.tar.gz servo-2382d71242b1f9fe6385b64436f3b18f8f0939bb.zip | |
auto merge of #5164 : luniv/servo/viewport-length-units-reftests, r=jdm
Looking for some review, due to a couple of issues:
* The vmin/vmax tests fail due to exit status being 1 instead of 0. However, when I manually check them via `./mach run tests/ref/viewport_percentage_vmax_vmin{,a,b,c}.html`, the pages render correctly
* Resizing is incredibly flaky. I've checked (via logging), and the actual calculation of the computed length is correct for a given viewport size. However, the box dimensions end up all over the place. I've attached a screenshot to demonstrate (the box is supposed to cover the top-left quarter of the window).
Fixes #5165.
| -rw-r--r-- | tests/ref/basic.list | 4 | ||||
| -rw-r--r-- | tests/ref/viewport_percentage_vmin_vmax.html | 16 | ||||
| -rw-r--r-- | tests/ref/viewport_percentage_vmin_vmax_a.html | 16 | ||||
| -rw-r--r-- | tests/ref/viewport_percentage_vmin_vmax_b.html | 16 | ||||
| -rw-r--r-- | tests/ref/viewport_percentage_vw_vh.html | 16 | ||||
| -rw-r--r-- | tests/ref/viewport_percentage_vw_vh_a.html | 16 | ||||
| -rw-r--r-- | tests/ref/viewport_percentage_vw_vh_b.html | 16 |
7 files changed, 100 insertions, 0 deletions
diff --git a/tests/ref/basic.list b/tests/ref/basic.list index 88f27cbfc00..e568e5e2311 100644 --- a/tests/ref/basic.list +++ b/tests/ref/basic.list @@ -274,6 +274,10 @@ flaky_cpu,experimental == vertical-lr-blocks.html vertical-lr-blocks_ref.html == vertical_align_top_a.html vertical_align_top_ref.html == vertical_align_top_bottom_a.html vertical_align_top_bottom_ref.html == vertical_align_top_span_a.html vertical_align_top_span_ref.html +resolution=800x600 == viewport_percentage_vmin_vmax.html viewport_percentage_vmin_vmax_a.html +resolution=600x800 == viewport_percentage_vmin_vmax.html viewport_percentage_vmin_vmax_b.html +resolution=800x600 == viewport_percentage_vw_vh.html viewport_percentage_vw_vh_a.html +resolution=600x800 == viewport_percentage_vw_vh.html viewport_percentage_vw_vh_b.html == visibility_hidden.html visibility_hidden_ref.html == whitespace_nowrap_a.html whitespace_nowrap_ref.html == whitespace_pre.html whitespace_pre_ref.html diff --git a/tests/ref/viewport_percentage_vmin_vmax.html b/tests/ref/viewport_percentage_vmin_vmax.html new file mode 100644 index 00000000000..370245a384b --- /dev/null +++ b/tests/ref/viewport_percentage_vmin_vmax.html @@ -0,0 +1,16 @@ +<!DOCTYPE html> +<html> + <head> + <style> + #box { + background: green; + height: 50vmax; + width: 50vmin; + } + </style> + </head> + <body> + <div id="box"> + </div> + </body> +</html> diff --git a/tests/ref/viewport_percentage_vmin_vmax_a.html b/tests/ref/viewport_percentage_vmin_vmax_a.html new file mode 100644 index 00000000000..d67f728bc8f --- /dev/null +++ b/tests/ref/viewport_percentage_vmin_vmax_a.html @@ -0,0 +1,16 @@ +<!DOCTYPE html> +<html> + <head> + <style> + #box { + background: green; + height: 400px; + width: 300px; + } + </style> + </head> + <body> + <div id="box"> + </div> + </body> +</html> diff --git a/tests/ref/viewport_percentage_vmin_vmax_b.html b/tests/ref/viewport_percentage_vmin_vmax_b.html new file mode 100644 index 00000000000..d67f728bc8f --- /dev/null +++ b/tests/ref/viewport_percentage_vmin_vmax_b.html @@ -0,0 +1,16 @@ +<!DOCTYPE html> +<html> + <head> + <style> + #box { + background: green; + height: 400px; + width: 300px; + } + </style> + </head> + <body> + <div id="box"> + </div> + </body> +</html> diff --git a/tests/ref/viewport_percentage_vw_vh.html b/tests/ref/viewport_percentage_vw_vh.html new file mode 100644 index 00000000000..11e6f5b00bf --- /dev/null +++ b/tests/ref/viewport_percentage_vw_vh.html @@ -0,0 +1,16 @@ +<!DOCTYPE html> +<html> + <head> + <style> + #box { + background: green; + height: 50vh; + width: 50vw; + } + </style> + </head> + <body> + <div id="box"> + </div> + </body> +</html> diff --git a/tests/ref/viewport_percentage_vw_vh_a.html b/tests/ref/viewport_percentage_vw_vh_a.html new file mode 100644 index 00000000000..116b3a05481 --- /dev/null +++ b/tests/ref/viewport_percentage_vw_vh_a.html @@ -0,0 +1,16 @@ +<!DOCTYPE html> +<html> + <head> + <style> + #box { + background: green; + height: 300px; + width: 400px; + } + </style> + </head> + <body> + <div id="box"> + </div> + </body> +</html> diff --git a/tests/ref/viewport_percentage_vw_vh_b.html b/tests/ref/viewport_percentage_vw_vh_b.html new file mode 100644 index 00000000000..d67f728bc8f --- /dev/null +++ b/tests/ref/viewport_percentage_vw_vh_b.html @@ -0,0 +1,16 @@ +<!DOCTYPE html> +<html> + <head> + <style> + #box { + background: green; + height: 400px; + width: 300px; + } + </style> + </head> + <body> + <div id="box"> + </div> + </body> +</html> |