diff options
| author | Hugo Thiessard <hugo.thiessard@opmbx.org> | 2016-09-21 23:50:18 +0200 |
|---|---|---|
| committer | Hugo Thiessard <hugo.thiessard@opmbx.org> | 2016-09-23 14:01:58 +0200 |
| commit | 0ac212afb18c98ea929368e9ccf21101e7a8921c (patch) | |
| tree | e1e551143e9af8ae1532a50acbc290aa474e8014 | |
| parent | 7b98c8a78819c57d90ed06c83f1376d4f38c8748 (diff) | |
| download | servo-0ac212afb18c98ea929368e9ccf21101e7a8921c.tar.gz servo-0ac212afb18c98ea929368e9ccf21101e7a8921c.zip | |
Issue #13350 Report tidy error for space after (
| -rw-r--r-- | components/script/dom/htmlformelement.rs | 2 | ||||
| -rw-r--r-- | python/tidy/servo_tidy/tidy.py | 1 | ||||
| -rw-r--r-- | python/tidy/servo_tidy_tests/rust_tidy.rs | 8 | ||||
| -rw-r--r-- | python/tidy/servo_tidy_tests/test_tidy.py | 3 |
4 files changed, 13 insertions, 1 deletions
diff --git a/components/script/dom/htmlformelement.rs b/components/script/dom/htmlformelement.rs index 268b04a159f..9622914b5b5 100644 --- a/components/script/dom/htmlformelement.rs +++ b/components/script/dom/htmlformelement.rs @@ -593,7 +593,7 @@ impl HTMLFormElement { "file" | "textarea" => (), // TODO _ => { datum.name = clean_crlf(&datum.name); - datum.value = FormDatumValue::String(clean_crlf( match datum.value { + datum.value = FormDatumValue::String(clean_crlf(match datum.value { FormDatumValue::String(ref s) => s, FormDatumValue::File(_) => unreachable!() })); diff --git a/python/tidy/servo_tidy/tidy.py b/python/tidy/servo_tidy/tidy.py index 081352f8a43..4b02f9dbf07 100644 --- a/python/tidy/servo_tidy/tidy.py +++ b/python/tidy/servo_tidy/tidy.py @@ -483,6 +483,7 @@ def check_rust(file_name, lines): (r"\{[A-Za-z0-9_]+\};", "use statement contains braces for single import", lambda match, line: line.startswith('use ')), (r"^\s*else {", "else braces should be on the same line", no_filter), + (r"[^$ ]\([ \t]", "extra space after (", no_filter), ] for pattern, message, filter_func in regex_rules: diff --git a/python/tidy/servo_tidy_tests/rust_tidy.rs b/python/tidy/servo_tidy_tests/rust_tidy.rs index 9bc37070613..358fce3a082 100644 --- a/python/tidy/servo_tidy_tests/rust_tidy.rs +++ b/python/tidy/servo_tidy_tests/rust_tidy.rs @@ -49,4 +49,12 @@ impl test { } } + type Text_Fun3 = fn( i32) -> i32; + + fn test_fun3<Text_Fun3>( y: Text_Fun3) { + test_fun( 1); + } + + // Should not be triggered + macro_rules! test_macro ( ( $( $fun:ident = $flag:ident ; )* ) => ()); } diff --git a/python/tidy/servo_tidy_tests/test_tidy.py b/python/tidy/servo_tidy_tests/test_tidy.py index 998967c617f..52371b944bb 100644 --- a/python/tidy/servo_tidy_tests/test_tidy.py +++ b/python/tidy/servo_tidy_tests/test_tidy.py @@ -109,6 +109,9 @@ class CheckTidiness(unittest.TestCase): self.assertEqual('use &T instead of &Root<T>', errors.next()[2]) self.assertEqual('operators should go at the end of the first line', errors.next()[2]) self.assertEqual('else braces should be on the same line', errors.next()[2]) + self.assertEqual('extra space after (', errors.next()[2]) + self.assertEqual('extra space after (', errors.next()[2]) + self.assertEqual('extra space after (', errors.next()[2]) self.assertNoMoreErrors(errors) def test_spec_link(self): |