aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbors-servo <metajack+bors@gmail.com>2014-10-06 12:21:30 -0600
committerbors-servo <metajack+bors@gmail.com>2014-10-06 12:21:30 -0600
commit06489fcc426ca65e807ea13d0d8fcf23bee3ca75 (patch)
treecf21954cfb4e538342a101825f1c173712ec5964
parentae4c9be536bcf386db5b6ad2603ecf874566f6ef (diff)
parent31f8100b9dd69e3301a7b049f160dc25ef3915c4 (diff)
downloadservo-06489fcc426ca65e807ea13d0d8fcf23bee3ca75.tar.gz
servo-06489fcc426ca65e807ea13d0d8fcf23bee3ca75.zip
auto merge of #3571 : Ms2ger/servo/rewrite-js-url, r=jdm
This should make it clearer that we always pass a URL to Document::new, and avoids an unnecessary unwrap() call.
-rw-r--r--components/script/script_task.rs14
1 files changed, 7 insertions, 7 deletions
diff --git a/components/script/script_task.rs b/components/script/script_task.rs
index 6520e0f258d..f3168e3e325 100644
--- a/components/script/script_task.rs
+++ b/components/script/script_task.rs
@@ -732,16 +732,16 @@ impl ScriptTask {
self.compositor.dup(),
self.image_cache_task.clone()).root();
let doc_url = if is_javascript {
- let doc_url = match last_url {
- Some(url) => Some(url.clone()),
- None => Url::parse("about:blank").ok(),
- };
- *page.mut_url() = Some((doc_url.as_ref().unwrap().clone(), true));
+ let doc_url = last_url.unwrap_or_else(|| {
+ Url::parse("about:blank").unwrap()
+ });
+ *page.mut_url() = Some((doc_url.clone(), true));
doc_url
} else {
- Some(url.clone())
+ url.clone()
};
- let document = Document::new(*window, doc_url, HTMLDocument, None).root();
+ let document = Document::new(*window, Some(doc_url), HTMLDocument,
+ None).root();
window.deref().init_browser_context(*document);