From b6b2c9d0c9510c4f945fdb39fc5d30d354272ca9 Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 24 Sep 2024 13:48:27 -0700
Subject: rdbms: improve Database::flushSnapshot() to use ROLLBACK sometimes

In case a DB handle ends up in STATUS_TRX_ERROR, use "ROLLBACK" so
that assertQueryIsCurrentlyAllowed() does not complain.

Also improved related Database::assessConnectionLoss() comments.

Change-Id: I39cee1363496dfe29e268a219b39070b23fdee4c
---
 .../integration/includes/db/DatabaseMysqlTest.php  | 72 ++++++++++++++++++++++
 1 file changed, 72 insertions(+)

(limited to 'tests')

diff --git a/tests/phpunit/integration/includes/db/DatabaseMysqlTest.php b/tests/phpunit/integration/includes/db/DatabaseMysqlTest.php
index c639670a125c..39a8fdb05610 100644
--- a/tests/phpunit/integration/includes/db/DatabaseMysqlTest.php
+++ b/tests/phpunit/integration/includes/db/DatabaseMysqlTest.php
@@ -3,6 +3,7 @@
 use MediaWiki\MediaWikiServices;
 use Wikimedia\Rdbms\ChangedTablesTracker;
 use Wikimedia\Rdbms\DatabaseMySQL;
+use Wikimedia\Rdbms\DBError;
 use Wikimedia\Rdbms\DBQueryDisconnectedError;
 use Wikimedia\Rdbms\DBQueryError;
 use Wikimedia\Rdbms\DBQueryTimeoutError;
@@ -11,6 +12,7 @@ use Wikimedia\Rdbms\DBTransactionStateError;
 use Wikimedia\Rdbms\DBUnexpectedError;
 use Wikimedia\Rdbms\IDatabase;
 use Wikimedia\Rdbms\Platform\ISQLPlatform;
+use Wikimedia\Rdbms\Platform\SQLPlatform;
 use Wikimedia\Rdbms\Query;
 use Wikimedia\Rdbms\TransactionManager;
 
@@ -152,6 +154,76 @@ class DatabaseMysqlTest extends \MediaWikiIntegrationTestCase {
 		$adminConn->close( __METHOD__ );
 	}
 
+	public function testConnectionLossSnapshotFlush() {
+		$fakeWriteQuery = new Query( 'SELECT 1', SQLPlatform::QUERY_CHANGE_ROWS, 'SELECT' );
+
+		$this->conn->begin( __METHOD__, IDatabase::TRANSACTION_INTERNAL );
+		$row = $this->conn->query( 'SELECT connection_id() AS id', __METHOD__ )->fetchObject();
+		$encId = intval( $row->id );
+
+		$adminConn = $this->newConnection();
+		$adminConn->query( "KILL $encId", __METHOD__ );
+
+		$this->conn->flushSnapshot( __METHOD__ );
+		$this->assertSame( 0, $this->conn->trxLevel(), "Lost connection during snapshot flush" );
+		$this->assertSame( TransactionManager::STATUS_TRX_NONE, $this->conn->trxStatus() );
+
+		$this->conn->begin( __METHOD__, IDatabase::TRANSACTION_INTERNAL );
+		$this->conn->query( $fakeWriteQuery, __METHOD__ );
+
+		$row = $this->conn->query( 'SELECT connection_id() AS id', __METHOD__ )->fetchObject();
+		$encId = intval( $row->id );
+		$adminConn->query( "KILL $encId", __METHOD__ );
+
+		try {
+			$this->conn->query( $fakeWriteQuery, __METHOD__ );
+			$this->fail( "Error thrown due to connection loss with pending writes" );
+		} catch ( DBError $e ) {
+			$this->assertInstanceOf( DBQueryDisconnectedError::class, $e );
+			$this->assertSame( TransactionManager::STATUS_TRX_ERROR, $this->conn->trxStatus() );
+		}
+
+		try {
+			$this->conn->query( 'SELECT 1', __METHOD__ );
+			$this->fail( "Error thrown due to unacknowledged transaction error" );
+		} catch ( DBError $e ) {
+			$this->assertInstanceOf( DBTransactionStateError::class, $e );
+			$this->assertSame( TransactionManager::STATUS_TRX_ERROR, $this->conn->trxStatus() );
+		}
+
+		$this->conn->flushSnapshot( __METHOD__ );
+		$this->assertSame( 0, $this->conn->trxLevel(), "Snapshot flush after lost writes" );
+		$this->assertSame( TransactionManager::STATUS_TRX_NONE, $this->conn->trxStatus() );
+
+		// Get a lock outside of any transaction
+		$unlocker = $this->conn->getScopedLockAndFlush( 'testing-key', __METHOD__, 0 );
+		// Start transaction *after* getting the lock
+		$this->conn->begin( __METHOD__, IDatabase::TRANSACTION_INTERNAL );
+
+		$row = $this->conn->query( 'SELECT connection_id() AS id', __METHOD__ )->fetchObject();
+		$encId = intval( $row->id );
+		$adminConn->query( "KILL $encId", __METHOD__ );
+
+		try {
+			$this->conn->query( 'SELECT 1', __METHOD__ );
+			$this->fail( "Error thrown due to connection loss with locks" );
+		} catch ( DBError $e ) {
+			$this->assertSame( TransactionManager::STATUS_TRX_ERROR, $this->conn->trxStatus() );
+		}
+
+		$this->conn->flushSnapshot( __METHOD__ );
+		$this->assertSame( 0, $this->conn->trxLevel(), "Snapshot flush with lost lock" );
+
+		try {
+			$this->conn->query( 'SELECT 1', __METHOD__ );
+			$this->fail( "Error thrown due to unacknowledged session error" );
+		} catch ( DBError $e ) {
+			$this->assertInstanceOf( DBSessionStateError::class, $e );
+		}
+
+		$adminConn->close( __METHOD__ );
+	}
+
 	public function testConnectionLossScopedLock() {
 		$row = $this->conn->query( 'SELECT connection_id() AS id', __METHOD__ )->fetchObject();
 		$encId = intval( $row->id );
-- 
cgit v1.2.3