From bc5cb7ae644bb8788499961dc6b009cb6f8b3a5e Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Mon, 15 Jun 2020 12:46:22 +0200 Subject: phan: Enable redundant_condition_detection Remove duplicate casts Suppress false positives Bug: T248438 Change-Id: I2f89664a4bcd3b39b15e7cf850adda2f0c90ae6f --- includes/resourceloader/ResourceLoaderFileModule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'includes/resourceloader/ResourceLoaderFileModule.php') diff --git a/includes/resourceloader/ResourceLoaderFileModule.php b/includes/resourceloader/ResourceLoaderFileModule.php index 4fe399f4d74a..477df3d38260 100644 --- a/includes/resourceloader/ResourceLoaderFileModule.php +++ b/includes/resourceloader/ResourceLoaderFileModule.php @@ -730,7 +730,7 @@ class ResourceLoaderFileModule extends ResourceLoaderModule { */ protected static function collateFilePathListByOption( array $list, $option, $default ) { $collatedFiles = []; - foreach ( (array)$list as $key => $value ) { + foreach ( $list as $key => $value ) { if ( is_int( $key ) ) { // File name as the value if ( !isset( $collatedFiles[$default] ) ) { -- cgit v1.2.3