From a06e3d06b11dfb2198229f4fe7f5b70609df2f20 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Thu, 13 Feb 2020 21:24:10 +1100 Subject: Fix some PHPStorm inspection warnings in includes/api Notably: * In ApiManageTags, I used a switch instead of a dynamic function name, so that the call graph will be correct. * In ApiImageRotate, checkTitleUserPermissions() has always returned void, this was an error introduced in 4e6810e4a2c1d821d8d108c Change-Id: Iea22616b8e7e2e0cc804619a54f8690898b2cb82 --- includes/api/ApiQueryUserContribs.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'includes/api/ApiQueryUserContribs.php') diff --git a/includes/api/ApiQueryUserContribs.php b/includes/api/ApiQueryUserContribs.php index ac8018de4b5c..4223e26f67f0 100644 --- a/includes/api/ApiQueryUserContribs.php +++ b/includes/api/ApiQueryUserContribs.php @@ -36,7 +36,10 @@ class ApiQueryUserContribs extends ApiQueryBase { parent::__construct( $query, $moduleName, 'uc' ); } - private $params, $multiUserMode, $orderBy, $parentLens, $commentStore; + private $params, $multiUserMode, $orderBy, $parentLens; + + /** @var CommentStore */ + private $commentStore; private $fld_ids = false, $fld_title = false, $fld_timestamp = false, $fld_comment = false, $fld_parsedcomment = false, $fld_flags = false, -- cgit v1.2.3