aboutsummaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Add optional serialization_type and hmac_key param values to RESTBagOStuffBill Pirkle2019-10-081-5/+53
| | | | | | | | | | | | | | | | T233537 made RESTBagOStuff work with the Kask external session storage service, but broke backward compatibility. Add optional values to the RESTBagOStuff $params constructor parameter to support communicating with Kask, and to allow using HMAC. The new values are: serialization_type: legacy (default), PHP, or JSON hmac_key: HMAC key to use for protecting the serialized blob If these new values are not specified, behavior remains unchanged (PHP serialization with no HMAC protection). Bug: T233963 Change-Id: Ia2625c04e08cfe9616569500f1d613be73c170a2 (cherry picked from commit 2ed69af15cb8971e35aafc2c08397ed38c480488)
* Merge "Disable flaky Selenium test" into REL1_34jenkins-bot2019-10-081-1/+1
|\
| * Disable flaky Selenium testReedy2019-10-081-1/+1
| | | | | | | | | | Bug: T226144 Change-Id: Ib49898617ba419f709b249ae9a05d9cb7b8e4e9d
* | Merge "Services: Convert LocalisationCache's static to a const now HHVM is ↵jenkins-bot2019-10-081-1/+1
|\ \ | | | | | | | | | gone" into REL1_34
| * | Services: Convert LocalisationCache's static to a const now HHVM is goneJames D. Forrester2019-10-081-1/+1
| | | | | | | | | | | | | | | Change-Id: If5c015debed7efc034613b976bc5292ac30036d7 (cherry picked from commit ebac0247cf38b45a253042be16998c7fffbffcbc)
* | | Merge "Make LocalisationCache a service" into REL1_34jenkins-bot2019-10-088-18/+105
|\| |
| * | Make LocalisationCache a serviceAryeh Gregor2019-10-088-18/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes Language::$dataCache without deprecation, because 1) I don't know of a way to properly simulate it in the new paradigm, and 2) I found no direct access to the member outside of the Language and LanguageTest classes. An earlier version of this patch (e4468a1d6b6) had to be reverted because of a massive slowdown on test runs. Based on some local testing, this should fix the problem. Running all tests in languages is slowed down by only around 20% instead of a factor of five, and memory usage is actually reduced greatly (~350 MB -> ~200 MB). The slowdown is still not great, but I assume it's par for the course for converting things to services and is acceptable. If not, I can try to optimize further. Bug: T231220 Bug: T231198 Bug: T231200 Bug: T201405 Change-Id: Ieadbd820379a006d8ad2d2e4a1e96241e172ec5a (cherry picked from commit 043d88f680cf66c90e2bdf423187ff8b994b1d02)
* | | Merge "Services: Convert DefaultPreferencesFactory's static to a const now ↵jenkins-bot2019-10-081-1/+1
|\ \ \ | |/ / |/| | | | | HHVM is gone" into REL1_34
| * | Services: Convert DefaultPreferencesFactory's static to a const now HHVM is goneJames D. Forrester2019-10-081-1/+1
| |/ | | | | | | | | Change-Id: If24c5f120cb96311b50750c5b3022664dc6b20e5 (cherry picked from commit 17f3f9cee31cd3aab4370808871309d9de5a87f9)
* | Services: Convert PasswordReset's static to a const now HHVM is goneJames D. Forrester2019-10-081-1/+1
| | | | | | | | | | Change-Id: I77e0d9ce86cf96824eb672d0f35c32b5f4c484be (cherry picked from commit 662b27776b0df77f31e9767bfbecd8bf0ca6ef93)
* | Optionally require both username and email for password resetsMax Semenik2019-10-081-49/+404
|/ | | | | | Bug: T232694 Change-Id: I70ed25ea4f810bf642fcb3df6f9b2663732b5dcf (cherry picked from commit 1de3611539dbef2df2b9c0a4632aecd066695990)
* Merge "Services: Convert BlockManager's static to a const now HHVM is gone" ↵jenkins-bot2019-10-081-1/+1
|\ | | | | | | into REL1_34
| * Services: Convert BlockManager's static to a const now HHVM is goneJames D. Forrester2019-10-081-1/+1
| | | | | | | | | | Change-Id: I01d6e18fc30bd61ba7ea5ce1c7c646524579c4ba (cherry picked from commit 40c35286cbf11a12c855eb9ffa722b867028564b)
* | Services: Convert PermissionManager's static to a const now HHVM is goneJames D. Forrester2019-10-081-1/+1
|/ | | | | Change-Id: Ib75b6f5d6b3e793ddbce42951693d8c99e6b7e57 (cherry picked from commit 9cba9f8567ade9a142a49a75b834d1b938c18336)
* Merge "Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32" ↵jenkins-bot2019-10-074-42/+19
|\ | | | | | | into REL1_34
| * Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32James D. Forrester2019-10-074-42/+19
| | | | | | | | | | | | | | | | Also move the 'unit' test into integration, given it tests code using globals. Change-Id: Ie039cae9b5d2870c18a6deefec9a73de522dd847 (cherry picked from commit 5b3bbd5adea327912694745db9c53d5d39de3315)
* | Turn PasswordReset into a serviceMax Semenik2019-10-071-10/+34
|/ | | | | | | | My team has plans to work in this area, better make it more testable. Bug: T232694 Change-Id: I200874ec10db69378ada1743b2a7953b3fa01e3e (cherry picked from commit 631f56c5766f582f21dd35eff0376b14692aa145)
* Merge "tests: Fix broken assertion in ApiQueryAllPagesTest"jenkins-bot2019-10-011-2/+1
|\
| * tests: Fix broken assertion in ApiQueryAllPagesTestThiemo Kreuz2019-09-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The description had two errors: * It talked about the presence of a specific value, but all it did was checking a count. * It was talking about the value *not* being there. I just removed it. The possible error message from PHPUnit should be good enough. Change-Id: I7ea85dd37db8969bdd120f9600eeb6145e42eb1e
* | selenium: Replace ES5 one-var assignments with const/let per lineTimo Tijhof2019-10-0110-54/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The one-var rule only applies to 'var' where it matters that we don't let the engine implicitly hoist variables leading to confusing code that may be unsafe to refactor in a straight-forward manner. This doesn't apply to ES6 const and let. While I updated the rule in 1955a8aa5 to allow ES6, I did not enforce it. Fixed now. When assigning a value, each assignment should be its own statement (disallow awkward comma separated assignments). When not assigning a value, and the lines are next to each other, they should be in one statement. This makes sense for this small directory and might make sense to propose for the wikimedia preset at some point. Note that the rule I added was not required to make the build pass. The changes I made are allowed by default by the wikimedia preset for es6+. The rule I added disallows the previous way. Change-Id: I26cda095a8a4589084e36273038877f2dd1fc50b
* | Merge "Selenium: Hide VE welcome and beta dialogs"jenkins-bot2019-09-304-19/+1
|\ \
| * | Selenium: Hide VE welcome and beta dialogsKosta Harlan2019-09-304-19/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Remove uses of setLocalStorage (incompatible with chromedriver >= 75) and also requires slightly fewer requests since BlankPage.open() doesn't need to be invoked. Bug: T234002 Change-Id: I4cfb4fe17a3c99bfcb7ff39ac6db60f5c5e8a687
* | | Merge "RevisionStore::newRevisionFromBatch should use Title::newFromRow"jenkins-bot2019-09-301-2/+20
|\ \ \ | |/ / |/| |
| * | RevisionStore::newRevisionFromBatch should use Title::newFromRowPetr Pchelko2019-09-301-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | If the rows were obtained using RevisionStore::getQueryInfo with 'page' flags, the revision row already contains the fields needed to construct the Title without an additional database query. Change-Id: Ie36c85871a8996a5706c80d286854a9c8363905f
* | | Merge "selenium: Fix inefficient use of MWBot in specs/page.js"jenkins-bot2019-09-301-46/+34
|\ \ \
| * | | selenium: Fix inefficient use of MWBot in specs/page.jsTimo Tijhof2019-09-301-46/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test previously took 4 minutes to run locally and ended up running the MWBot.login process 9 times. After this, the specs/page tests only log-in once. Bug: T234002 Change-Id: I374620a01f49d4da559070d0982bdbe4c1269e2e
* | | | Merge "selenium: Use async-await for wdio-mediawiki/Api internals"jenkins-bot2019-09-301-51/+39
|\| | | | |/ / |/| |
| * | selenium: Use async-await for wdio-mediawiki/Api internalsTimo Tijhof2019-09-301-51/+39
| | | | | | | | | | | | | | | Bug: T234002 Change-Id: Ie4ad5248f832dd57f35710e0e9a91250e061b0bb
* | | Merge "selenium: Remove "RunJobs" wait from specialrecentchanges test"jenkins-bot2019-09-301-3/+1
|\| |
| * | selenium: Remove "RunJobs" wait from specialrecentchanges testTimo Tijhof2019-09-291-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test was consistently reaching the RunJobs timeout of 10 tries and then giving up. This happens in CI, where it wasted about ~ 5 seconds, and locally where it takes about 30s for mw. Like so: > RunJobs through requests to the main page (run 1). > RunJobs detected 12 more queued job(s). > RunJobs through requests to the main page (run 2). > RunJobs detected 12 more queued job(s). Etc, until it reaches run 10 and gives up. This also suggests the whole thing isn't wokring, but that's a separate matter. First and foremost, RecentChange objects are saved from a PRESEND deferred update, which means it does not require a job queue wait in order to appear on Special:RecentChanges. This was added in e908d347ef2 (T199446) "to keep the number of unrun jobs low". The idea being that this test makes an edit via the API, which means it creates jobs without running them. On the other hand, there's also lots of test steps that view pages but don't create jobs, which would make this optimisation premature. If and when we do encounter a test failing due to a job backlog, I'm confident we can find a better solution at that time. Bug: T234002 Bug: T225730 Bug: T199446 Change-Id: I9ef8c5b65d4b636572569912f04f48ed40aa0564
* | | Merge "selenium: Remove deprecated legacy methods"jenkins-bot2019-09-305-39/+3
|\ \ \
| * | | selenium: Remove deprecated legacy methodsTimo Tijhof2019-09-295-39/+3
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are from 2018, prior to introducing wdio-mediawiki in commit 16a4d9da7bb81. Some extensions referenced these pageobjects files through escalating "../../" references. None of these are seen in Codesearch anymore, as well as no references to these deprecated methods by other means. Change-Id: Idbc373f13f9767cecd6404922b5c9773d796dda5
* | | Merge "selenium: Upgrade from webdriver v4 to v5"jenkins-bot2019-09-3026-166/+132
|\| |
| * | selenium: Upgrade from webdriver v4 to v5Timo Tijhof2019-09-2926-166/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Options no longer needed or no longer exist in wdio v5: - coloredLogs: Now always on. The underlying 'chalk' library can still be influenced via the FORCE_COLOR environment variable. - screenshotPath: Removed. Was already disabled in our config. - deprecationWarnings: Meh. - 'sync: true' – On by default when `@wdio/sync` is installed. The wdio v5 config generator doesn't recommend setting manually. * The selenium.sh script was removed. It existed to start and stop chromedriver for local use by developers. This is now done by the wdio-chromedriver-service. In WMF CI, Quibble starts its own chromedriver (as optimisation, reused across gated repos), which is why the 'selenium-test' entry points remains and skips this. * The wdio-mediawiki package now requires wdio v5 and Node 10. This doesn't affect extension repos because versions are pinned. Upgrade may happen at the earliest convenience. * Several WDIO methods changed names or signature. Full list at: <https://github.com/webdriverio/webdriverio/blob/v5.13.2/CHANGELOG.md#v500-2018-12-20> Highlights: - browser.element() is now browser.findElement() with "$()" as alias. - browser.localStorage replaced by browser.setLocalStorage. - browser.deleteCookie() requires `name` param. To delete all at once, there is a new method browser.deleteAllCookies(). - Commands that return data no longer wrapped in `{ value: … }`. Values are now returned directly. - Custom config keys are now under browser.config instead of browser.options. Renamed our username/password keys to be mw-prefixed, to avoid clashes and reduce confusion with similar config keys. - browser.click(selector) and browser.getText(selector) no longer exist. Use $(selector).click() or .getText() instead. * Fix "no such alert" warning from specs/page.js by removing the apparently redundant code. Bug: T234002 Bug: T213268 Change-Id: I908997569ca8457997af30cb29e98ac41fae3b64
* | | Merge "RevisionStore: Introduce getContentBlobsForBatch"jenkins-bot2019-09-303-1/+207
|\ \ \
| * | | RevisionStore: Introduce getContentBlobsForBatchdaniel2019-09-273-1/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | getContentBlobsForBatch provides a more low level interface than newRevisionsFromBatch, allowing bulk access to serialized content without the need to instantiate Title, RevisionRecord, RevisionSlots, SlotRecord, and Content objects. Bug: T228675 Bug: T234034 Change-Id: I8481ad211e2d9f11bc10ea10c16e78b74538d95b
* | | | tests: Replace assertions on count() == 0 with strict === []Thiemo Kreuz2019-09-303-3/+3
| |_|/ |/| | | | | | | | | | | | | | | | | | | | The benefit of using count() is that the test would still succeed if the return vfalue is not an array, but an iterable object. It seems this is not needed. Change-Id: I23529f6990aebe0cce86e236a21820fe74993204
* | | Merge "selenium: Restore sauce user/key configuration for wdio"jenkins-bot2019-09-301-0/+3
|\ \ \ | | |/ | |/|
| * | selenium: Restore sauce user/key configuration for wdioTimo Tijhof2019-09-291-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I removed these in e78484109ae7 because they seemed redundant given that the library used by wdio-sauce-service already reads these when present. However, our current version of this package clobbers this unconditionally with config.user/config.key, thus not letting it reach that default. Also add sauceConnect:true which means developers can run localhost tests against sauce labs if they so choose. Change-Id: I8d31a23374b2b9b6cd6f1405c7a2f1001da08f1a
* | | Expand testDoQuickOperations() tests for FileBackendAaron Schulz2019-09-291-57/+117
|/ / | | | | | | Change-Id: I0633f13f07b5a3234b9bbae4840b064972f68fd9
* | Merge "resourceloader: Add version to ResourceLoaderImage urls for long-cache"jenkins-bot2019-09-281-13/+1
|\ \
| * | resourceloader: Add version to ResourceLoaderImage urls for long-cacheTimo Tijhof2019-09-281-13/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code previously here did not work well as it merely forwarded the hash from the current web request. This had numerous issues: 1. It was often null because requests for stylesheets do not cary a version hash. 2. When requested by JavaScript, the version hash would be a combination-hash of many unrelated modules, thus when requested as part of different batches, it would produce different urls which is not ideal. The impact of this is minimal currently because we basically never use these urls, as SVGs are almost always embedded instead of ref'ed by url. PNG urls are only generated for non-JS modules and then only used in older browsers not supporting SVG. And, even after all that, for the edge case of an SVG being ref'ed by url, they would be stored in LocalStorage by mw.loader with the name+version of the module the image belonged to, not the version hash of the batch request it came with. Which means that, yes, localstorage key for "somemodule+someversion" would have different values for different users, based on which batch the value came with, because the image urls were using the version hash of the batch request from ResourceLoaderContext. This is weird, but didn't cause bugs or inefficiencies because the user would never be exposed to the other possible urls for that image because we always check LocalStorage first. It did cause fragmentation server-side in Varnish, though. This is all fixed now by always including a version, and setting it to the version of the module. This means there is no more Varnish fragmentation for these. And it means that browsers are now allowed to cache the images served from these urls for 30+ days (immutable) instead of only 5min, which is what happened when they didn't have a version parameter (or set to null). Bug: T233343 Change-Id: I4af7fda03698ed4c288d154e7787fb2f3cbbe6c5
* | | Merge "resourceloader: Simplify makeLoaderStateScript and ↵jenkins-bot2019-09-281-6/+0
|\ \ \ | | | | | | | | | | | | makeLoaderSourcesScript"
| * | | resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScriptFomafix2019-09-281-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | The signatures without array are not used anymore. Change-Id: Ice6a09ff6cba0c605ed1c89a25fd8e02af041b05
* | | | StringUtils: Clarify that isValidRegex is for PCRE regexpsDaimona Eaytoy2019-09-281-4/+5
|/ / / | | | | | | | | | | | | | | | As suggested in c14571ba26e (I257a096319f1e). Change-Id: Ia91d037f2f4bf8a1bad4eac65fecb1d3e2679d2d
* | | Merge "tests: Replace PHPUnit's loose assertEquals(null) with assertNull()"jenkins-bot2019-09-2714-37/+35
|\ \ \
| * | | tests: Replace PHPUnit's loose assertEquals(null) with assertNull()Thiemo Kreuz2019-09-2714-37/+35
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assertEquals( null, … ) still succeeds when the actual value is 0, false, an empty string, even an empty array. All these should be reported as a failure, I would argue. Note this patch previously also touched assertSame( null ). I reverted these. The only benefit would have been consistency within this codebase, but there is no strict reason to prefer one over the other. assertNull() and assertSame( null ) are functionally identical. Change-Id: I92102e833a8bc6af90b9516826abf111e2b79aac
* | | Merge "Remove tests that were skipped for MCR-enabled schema"jenkins-bot2019-09-271-136/+0
|\ \ \
| * | | Remove tests that were skipped for MCR-enabled schemaPetr Pchelko2019-09-271-136/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pre-MCR schema is no longer supported, thus we don't need the tests that are skipped for MCR-enabled schema. Bug: T214308 Change-Id: I2d78ec668fde1e49710c54be8ab72c474f30f6b8
* | | | Merge "resourceloader: Add $context to static functions in ResourceLoader"jenkins-bot2019-09-272-13/+24
|\ \ \ \ | |/ / / |/| | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 21:50:28 +0000